Skip to content

Optional detailed report on the BasicCCDBManager cache#12430

Merged
shahor02 merged 3 commits into
AliceO2Group:devfrom
shahor02:pr_repccdb
Jan 8, 2024
Merged

Optional detailed report on the BasicCCDBManager cache#12430
shahor02 merged 3 commits into
AliceO2Group:devfrom
shahor02:pr_repccdb

Conversation

@shahor02

Copy link
Copy Markdown
Collaborator

@ktf @jgrosseo this PR extends the report of the BasicCCDBManager statistics to the same detailed level as produced by the DPL CCDBHelper. One should explicitly call BasicCCDBManager::instance().report(true) to have the extended report, by default only the old summary string is printed:

auto& cc = o2::ccdb::BasicCCDBManager::instance();
cc.get<o2::parameters::GRPECSObject>("GLO/Config/GRPECS");
cc.setTimestamp(17021636063139);
cc.get<o2::parameters::GRPECSObject>("GLO/Config/GRPECS"); // fails as the timestamp is bogus;
cc.setTimestamp(1702163606313);
cc.get<o2::parameters::GRPECSObject>("GLO/Config/GRPECS");
cc.get<o2::parameters::GRPECSObject>("GLO/Config/GRPECS");
cc.get<o2::parameters::GRPECSObject>("GLO/Config/GRPECS");
cc.get<TGeoManager>("GLO/Config/Geometry");
cc.get<TGeoManager>("GLO/Config/Geometry");

cc.report(true);
[INFO] CCDBManager summary: 7 queries for 2 objects, 3 good fetches (and 0 failed ones) in 4,009 ms, instance: alicrs02-1702170696-lhV1VF
[INFO] CCDB cache miss/hit/failures
[INFO]   GLO/Config/Geometry: 1/1/0 (1883722-1883722 bytes)
[INFO]   GLO/Config/GRPECS: 2/2/1 (1809-1820 bytes)

Let me know what exactly you want to send to the monitoring, I will prepare a getter for corresponding Metric.

@shahor02 shahor02 requested review from a team, Barthelemy, costing and sawenzel as code owners December 10, 2023 01:28
@jgrosseo

Copy link
Copy Markdown
Collaborator

Thanks. This looks very good.
I only had the plan to harvest the total transferred bytes (what are the ranges actually?)
Nevertheless, as you have it by object, you could send all that info to monitoring per object (if someone else needs that) and I can do the aggregation on my side. I let @ktf in which structure to send this back.

@shahor02

Copy link
Copy Markdown
Collaborator Author

The printout corresponds to what @ktf did for the DPL fetcher (+ number of failures per object, since the BasicCCDBManager is allowed to go over them): range is the min and max size of the object for given path.

I am afraid sending per object info to monitoring will require 1 metric per object, not sure if it is not too much, perhaps @ktf may comment.

@shahor02

Copy link
Copy Markdown
Collaborator Author

@jgrosseo I've added a getter

size_t o2::ccdb::BasicCCDBManager::getFetchedSize();

Let me know if this is enough, then I'll merge this.

@alibuild

alibuild commented Dec 14, 2023

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for ad12117 at 2023-12-16 09:58:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/QualityControl-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc8_x86-64/O2/12430-slc8_x86-64-local1/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 1


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/2f7505c60144794742d7a053de073f7ebc17fe39/slc8_x86-64/o2checkcode/1.0-local512/etc/modulefiles
++ cat
--

Full log here.

@shahor02

shahor02 commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator Author

@jgrosseo merging this, if extra methods are needed, let me know, will do in other PR.

@shahor02 shahor02 merged commit 3301b3f into AliceO2Group:dev Jan 8, 2024
@shahor02 shahor02 deleted the pr_repccdb branch January 8, 2024 15:02
cholmcc pushed a commit to cholmcc/AliceO2 that referenced this pull request Jan 17, 2024
…12430)

* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…12430)

* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…12430)

* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
…12430)

* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
benedikt-voelkel pushed a commit that referenced this pull request May 6, 2024
* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
benedikt-voelkel pushed a commit to benedikt-voelkel/AliceO2 that referenced this pull request May 14, 2024
…12430)

* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
benedikt-voelkel pushed a commit that referenced this pull request May 14, 2024
* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
benedikt-voelkel pushed a commit that referenced this pull request May 14, 2024
* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
(cherry picked from commit 3301b3f)
benedikt-voelkel pushed a commit that referenced this pull request May 16, 2024
* Add to the headers the ccdb fileSize entry

* Optional detailed report on BasicCCDBManager cache

* Add gettet for the total fetched size

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
(cherry picked from commit 3301b3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants