Skip to content

TPC: several unrelated fixes and improvements #13079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wiechula merged 4 commits into from
Apr 26, 2024
Merged

TPC: several unrelated fixes and improvements #13079

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e59d8c
Add calculation of mean values over all sectors
wiechula Apr 25, 2024
721b938
Add missing forward of template parameters, cleanup
wiechula Apr 25, 2024
54301c7
Add summary canvases from pad tree dump, cosmetic fixes
wiechula Apr 25, 2024
4e353ed
Possibility to load specific pedestal object for IDCs
wiechula Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Possibility to load specific pedestal object for IDCs
  • Loading branch information
@wiechula
wiechula committed Apr 25, 2024
commit 4e353ed2e43f5ad4f34cc206c94a76ab0bac3ad5
31 changes: 19 additions & 12 deletions Detectors/TPC/workflow/src/IDCToVectorSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,31 +80,38 @@ class IDCToVectorDevice : public o2::framework::Task

auto pedestalFile = ic.options().get<std::string>("pedestal-url");
if (pedestalFile.length()) {
if (pedestalFile.find("ccdb") != std::string::npos) {
if (pedestalFile.find("-default") != std::string::npos) {
pedestalFile = o2::base::NameConf::getCCDBServer();
auto& cdb = o2::ccdb::BasicCCDBManager::instance();
long timeStamp = o2::ccdb::getCurrentTimestamp();
const auto tsPos = pedestalFile.find("@");
std::string pedestalURL = pedestalFile.substr(0, tsPos);
if (pedestalURL.find("ccdb") != std::string::npos) {
if (pedestalURL.find("-default") != std::string::npos) {
pedestalURL = o2::base::NameConf::getCCDBServer();
}
LOGP(info, "Loading pedestals from ccdb: {}", pedestalFile);
auto& cdb = o2::ccdb::BasicCCDBManager::instance();
cdb.setURL(pedestalFile);
LOGP(info, "Loading pedestals from ccdb: {}", pedestalURL);
cdb.setURL(pedestalURL);
if (cdb.isHostReachable()) {
auto pedestalNoise = cdb.get<std::unordered_map<std::string, CalPad>>("TPC/Calib/PedestalNoise");
if (tsPos != std::string::npos) {
timeStamp = std::stol(pedestalFile.substr(tsPos + 1));
LOGP(info, "Using custom time stamp {}", timeStamp);
}
auto pedestalNoise = cdb.getForTimeStamp<std::unordered_map<std::string, CalPad>>("TPC/Calib/PedestalNoise", timeStamp);
try {
if (!pedestalNoise) {
throw std::runtime_error("Couldn't retrieve PedestaNoise map");
}
mPedestal = std::make_unique<CalPad>(pedestalNoise->at("Pedestals"));
} catch (const std::exception& e) {
LOGP(fatal, "could not load pedestals from {} ({}), required for IDC processing", pedestalFile, e.what());
LOGP(fatal, "could not load pedestals from {} ({}), required for IDC processing", pedestalURL, e.what());
}
} else {
LOGP(fatal, "ccdb access to {} requested, but host is not reachable. Cannot load pedestals, required for IDC processing", pedestalFile);
LOGP(fatal, "ccdb access to {} requested, but host is not reachable. Cannot load pedestals, required for IDC processing", pedestalURL);
}
} else {
LOGP(info, "Loading pedestals from file: {}", pedestalFile);
auto calPads = utils::readCalPads(pedestalFile, "Pedestals");
LOGP(info, "Loading pedestals from file: {}", pedestalURL);
auto calPads = utils::readCalPads(pedestalURL, "Pedestals");
if (calPads.size() != 1) {
LOGP(fatal, "Pedestal could not be loaded from file {}, required for IDC processing", pedestalFile);
LOGP(fatal, "Pedestal could not be loaded from file {}, required for IDC processing", pedestalURL);
} else {
mPedestal.reset(calPads[0]);
}
Expand Down