Skip to content

DPL: introduce function to do forwarding on insertion #14958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktf wants to merge 2 commits into
base: dev
Choose a base branch
from
+36 −3
Open

DPL: introduce function to do forwarding on insertion #14958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9961552
DPL: split early forward function so that it does not depend on Messa…
ktf Jan 15, 2026
feb8854
DPL: introduce function to do forwarding on insertion
ktf Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions Framework/Core/src/DataProcessingDevice.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1680,6 +1680,33 @@ struct WaitBackpressurePolicy {
}
};

auto forwardOnInsertion(ServiceRegistryRef& ref, std::span<fair::mq::MessagePtr>& messages) -> void
{
O2_LOG_ENABLE(forwarding);
O2_SIGNPOST_ID_GENERATE(sid, forwarding);
auto& timesliceIndex = ref.get<TimesliceIndex>();
auto oldestTimeslice = timesliceIndex.getOldestPossibleOutput();
O2_SIGNPOST_START(forwarding, sid, "forwardInputs", "Starting forwarding for incoming data with oldestTimeslice %zu with copy.",
oldestTimeslice.timeslice.value);
auto& proxy = ref.get<FairMQDeviceProxy>();
std::vector<fair::mq::Parts> forwardedParts;
DataProcessingHelpers::routeForwardedMessages(proxy, messages, forwardedParts, true, false);

for (int fi = 0; fi < proxy.getNumForwardChannels(); fi++) {
if (forwardedParts[fi].Size() == 0) {
continue;
}
ForwardChannelInfo info = proxy.getForwardChannelInfo(ChannelIndex{fi});
auto& parts = forwardedParts[fi];
if (info.policy == nullptr) {
O2_SIGNPOST_EVENT_EMIT_ERROR(forwarding, sid, "forwardInputs", "Forwarding to %{public}s %d has no policy.", info.name.c_str(), fi);
continue;
}
O2_SIGNPOST_EVENT_EMIT(forwarding, sid, "forwardInputs", "Forwarding to %{public}s %d", info.name.c_str(), fi);
info.policy->forward(parts, ChannelIndex{fi}, ref);
}
};

/// This is the inner loop of our framework. The actual implementation
/// is divided in two parts. In the first one we define a set of lambdas
/// which describe what is actually going to happen, hiding all the state
Expand Down Expand Up @@ -1859,7 +1886,7 @@ void DataProcessingDevice::handleData(ServiceRegistryRef ref, InputChannelInfo&
input,
nMessages,
nPayloadsPerHeader,
nullptr,
forwardOnInsertion,
onDrop);
switch (relayed.type) {
case DataRelayer::RelayChoice::Type::Backpressured:
Expand Down Expand Up @@ -2274,9 +2301,15 @@ bool DataProcessingDevice::tryDispatchComputation(ServiceRegistryRef ref, std::v
bool consumeSomething = action.op == CompletionPolicy::CompletionOp::Consume || action.op == CompletionPolicy::CompletionOp::ConsumeExisting;

if (context.canForwardEarly && hasForwards && consumeSomething) {
O2_SIGNPOST_EVENT_EMIT(device, aid, "device", "Early forwainding: %{public}s.", fmt::format("{}", action.op).c_str());
auto& timesliceIndex = ref.get<TimesliceIndex>();
forwardInputs(ref, action.slot, currentSetOfInputs, timesliceIndex.getOldestPossibleOutput(), true, action.op == CompletionPolicy::CompletionOp::Consume);
auto oldestTimeslice = timesliceIndex.getOldestPossibleOutput();
auto& asyncQueue = ref.get<AsyncQueue>();
auto& decongestion = ref.get<DecongestionService>();
O2_SIGNPOST_ID_GENERATE(aid, async_queue);
O2_SIGNPOST_EVENT_EMIT(async_queue, aid, "forwardInputs", "Queuing forwarding oldestPossible %zu", oldestTimeslice.timeslice.value);
AsyncQueueHelpers::post(asyncQueue, AsyncTask{.timeslice = oldestTimeslice.timeslice, .id = decongestion.oldestPossibleTimesliceTask, .debounce = -1, .callback = decongestionCallbackLate}
.user<DecongestionContext>({.ref = ref, .oldestTimeslice = oldestTimeslice}));
O2_SIGNPOST_END(forwarding, sid, "forwardInputs", "Forwarding done");
}
markInputsAsDone(action.slot);

Expand Down