Skip to content

GRP DCS DP processing#8003

Merged
shahor02 merged 2 commits into
AliceO2Group:devfrom
chiarazampolli:GRPDPs
Jan 31, 2022
Merged

GRP DCS DP processing#8003
shahor02 merged 2 commits into
AliceO2Group:devfrom
chiarazampolli:GRPDPs

Conversation

@chiarazampolli

Copy link
Copy Markdown
Collaborator

Eg. to run:

o2-calibration-grp-dcs-dps-sim-workflow --max-timeframes 100 --delta-fraction 0.5 --max-cycles-no-full-map 3 | o2-calibration-grp-dcs-dps-workflow  | o2-calibration-ccdb-populator-workflow --ccdb-path http://localhost:8080

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startTime is a dummy counter, it cannot be used as an alias for the time. Moreover, when it comes from the dcs-proxy, where the TF has no usual meaning, it even cannot be converted to the abs. time.
If you want, I can change the dcs2dpl to send 'now()' in the DataProcessingHeader::creation, then you can use

auto creationTime = DataRefUtils::getHeader<DataProcessingHeader*>(pc.inputs().getFirstValid(true))->creation;

directly for the time. Alternatively, you can simply use now() here. But the most precise would be extracting the timestamp from the DP itself.

@chiarazampolli chiarazampolli Jan 27, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ruben,
This was the plan, I started with startTime more as a placeholder (see also our other mail exchange). I planned to add a comment to the PR, but I forgot :-)
I would use for each object probably the oldest time of all datapoints, or, as you say, "now".
This is something that should be changed in several places, which is also why I kind of postponed it.
In general, it would be better to change the dcs2dpl, also for the configurations.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to not use the timestamps of the measurements because they might be out of sync, and they could give the wrong message.
I am using now "creation", and if this is -1, then I use "now".
But I think we should set it in the proxy, same for the configurations.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then simply use

auto creationTime = DataRefUtils::getHeader<DataProcessingHeader*>(pc.inputs().getFirstValid(true))->creation;

I will add its filling to the proxy today.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I now have:

auto startValidity = o2::header::get<o2::framework::DataProcessingHeader*>(pc.inputs().get("input").header)->creation;

but I can change it to the one above (I guess they are equivalent, no?).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Comment thread Detectors/Calibration/include/DetectorsCalibration/Utils.h Outdated
@chiarazampolli

Copy link
Copy Markdown
Collaborator Author

Hi @TimoWilken , @ktf ,
macos is stuck, I think the same was reported somewhere else in other PRs, right?
@shahor02 , were the comments above the only ones you had?
Chiara

@shahor02 shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS is stuck since a few days, merging.

@shahor02
shahor02 merged commit 622003c into AliceO2Group:dev Jan 31, 2022
@chiarazampolli
chiarazampolli deleted the GRPDPs branch May 16, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants