DPL Analysis: Improve tests for persistent and index columns#9295
Merged
Conversation
Collaborator
Author
|
Hi, if you have time could you please look at this? Thanks a lot! |
ktf
reviewed
Jul 5, 2022
| template <typename T> | ||
| using is_dynamic_t = framework::is_specialization<typename T::base, DynamicColumn>; | ||
|
|
||
| namespace persistent_type_helper |
Member
There was a problem hiding this comment.
Not sure I like the idea of such a specific namespace. Do you really need it?
Collaborator
Author
There was a problem hiding this comment.
Then instead would you prefer the included functions to have a more specific name instead of test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ktf @aalkin
this is the first split from #9291 . I need
is_persistent_tto work also with types that do not contain thepersistentfield.I also improved the functions for getting index columns data to properly recognize different index kinds.