Skip to content

Change default setting of mult. axis for trackQC. - #1315

Merged
benedikt-voelkel merged 2 commits into
AliceO2Group:masterfrom
mfaggin:fixMultRangeTrackQC
Nov 6, 2023
Merged

Change default setting of mult. axis for trackQC.#1315
benedikt-voelkel merged 2 commits into
AliceO2Group:masterfrom
mfaggin:fixMultRangeTrackQC

Conversation

@mfaggin

@mfaggin mfaggin commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

Setting values to the new defaults as in AliceO2Group/O2Physics@505f13e

@benedikt-voelkel

Copy link
Copy Markdown
Contributor

Would it be a reasonable alternative to remove these specific settings from the config so that the default is take automatically? Then, in the future, people would rather implement specific values if needed.
What do you think @mfaggin ?

@mfaggin

mfaggin commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

Would it be a reasonable alternative to remove these specific settings from the config so that the default is take automatically? Then, in the future, people would rather implement specific values if needed. What do you think @mfaggin ?

Hi @benedikt-voelkel , indeed this is how I was thinking these json filesto behave. For some reasons, instead, those default values were copy-pasted. I'll change in the next commit.

@benedikt-voelkel

Copy link
Copy Markdown
Contributor

Great, thank you!
Yes, I agree - whenever there are defaults to be used - we should remove these key-value pairs in the JSONs so that in the future, people edit it only in case they need specific values.

@benedikt-voelkel
benedikt-voelkel merged commit 1c33c67 into AliceO2Group:master Nov 6, 2023
chiarazampolli pushed a commit that referenced this pull request Nov 7, 2023
* Change default setting of mult. axis for trackQC.
  --> Remove setting for binsTrackMultiplicity to use default.

---------

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
benedikt-voelkel pushed a commit that referenced this pull request Nov 17, 2023
* Change default setting of mult. axis for trackQC.
  --> Remove setting for binsTrackMultiplicity to use default.

---------

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
benedikt-voelkel pushed a commit to benedikt-voelkel/O2DPG that referenced this pull request Nov 28, 2023
* Change default setting of mult. axis for trackQC.
  --> Remove setting for binsTrackMultiplicity to use default.

---------

Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants