Skip to content

Add CTF size QC and pass active detector list#1620

Merged
chiarazampolli merged 2 commits into
AliceO2Group:masterfrom
martenole:ctfsize
Jun 5, 2024
Merged

Add CTF size QC and pass active detector list#1620
chiarazampolli merged 2 commits into
AliceO2Group:masterfrom
martenole:ctfsize

Conversation

@martenole

Copy link
Copy Markdown
Contributor

PR for QC follows later. This passes the list of active detectors to the QC task so that it can publish only the histograms for the active detectors

@github-actions

github-actions Bot commented May 8, 2024

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted
async-2023-pp-apass4
async-2023-pp-apass4-accepted

Comment thread DATA/production/qc-workflow.sh Outdated
# CTF QC
if [[ ! -z "${QC_JSON_CTF_SIZE:-}" ]]; then
add_QC_JSON GLO_CTF ${QC_JSON_CTF_SIZE}
add_pipe_separated QC_DETECTOR_CONFIG_OVERRIDE '.qc.tasks.CTFSize.taskParameters.detectors=${WORKFLOW_DETECTORS}'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably doesn't matter, but shouldn't this be WORKFLOW_DETECTORS_CTF?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all I want to achieve is that plots for one detector are not published by different runs, so WORKFLOW_DETECTORS is ok. In case for one detector CTF storage is disabled then the plots would show zero size which is fine I think.

@martenole

Copy link
Copy Markdown
Contributor Author

This should be tested in production first and could then be merged. On staging I did not manage to activate the GLO QC task on the QC merger node. The QC tasks on the EPNs ran fine. A good opportunity would be synthetics run, where this could be used from a local EPN checkout and if there are no problems this is good to go

@rmunzer

rmunzer commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

This should be tested in production first and could then be merged. On staging I did not manage to activate the GLO QC task on the QC merger node. The QC tasks on the EPNs ran fine. A good opportunity would be synthetics run, where this could be used from a local EPN checkout and if there are no problems this is good to go

I did a test with replay in production. Seems to run fine.

@chiarazampolli

Copy link
Copy Markdown
Collaborator

Thanks, since @rmunzer confirmed it is fine, I am merging.

Chiara

@chiarazampolli
chiarazampolli merged commit 4ab436a into AliceO2Group:master Jun 5, 2024
feisenhu pushed a commit to feisenhu/O2DPG that referenced this pull request Jul 1, 2024
* Add CTF size QC and pass active detector list

* Add missing quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants