Add CTF size QC and pass active detector list#1620
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| # CTF QC | ||
| if [[ ! -z "${QC_JSON_CTF_SIZE:-}" ]]; then | ||
| add_QC_JSON GLO_CTF ${QC_JSON_CTF_SIZE} | ||
| add_pipe_separated QC_DETECTOR_CONFIG_OVERRIDE '.qc.tasks.CTFSize.taskParameters.detectors=${WORKFLOW_DETECTORS}' |
There was a problem hiding this comment.
probably doesn't matter, but shouldn't this be WORKFLOW_DETECTORS_CTF?
There was a problem hiding this comment.
all I want to achieve is that plots for one detector are not published by different runs, so WORKFLOW_DETECTORS is ok. In case for one detector CTF storage is disabled then the plots would show zero size which is fine I think.
|
This should be tested in production first and could then be merged. On staging I did not manage to activate the GLO QC task on the QC merger node. The QC tasks on the EPNs ran fine. A good opportunity would be synthetics run, where this could be used from a local EPN checkout and if there are no problems this is good to go |
I did a test with replay in production. Seems to run fine. |
|
Thanks, since @rmunzer confirmed it is fine, I am merging. Chiara |
* Add CTF size QC and pass active detector list * Add missing quotes
PR for QC follows later. This passes the list of active detectors to the QC task so that it can publish only the histograms for the active detectors