Skip to content

New ITS MC Track task - #299

Merged
knopers8 merged 6 commits into
AliceO2Group:masterfrom
IsakovAD:IsakovAD_Added_ITSQC
Apr 7, 2022
Merged

New ITS MC Track task#299
knopers8 merged 6 commits into
AliceO2Group:masterfrom
IsakovAD:IsakovAD_Added_ITSQC

Conversation

@IsakovAD

Copy link
Copy Markdown
Contributor

Added new ITS MC Track task

Comment thread MC/config/QC/json/its-mc-tracks-qc.json Outdated
Comment thread MC/config/QC/json/its-mc-tracks-qc.json Outdated
Comment thread MC/config/QC/json/its-mc-tracks-qc.json Outdated
Comment thread MC/bin/o2dpg_sim_workflow.py Outdated
@IsakovAD

Copy link
Copy Markdown
Contributor Author

Dear @chiarazampolli. @knopers8

I have resolved issues in the new commit. Please, could you review changes?

@chiarazampolli

Copy link
Copy Markdown
Collaborator

Seems fine to me. @knopers8 ?
@IsakovAD , note that this PR is a Draft... Maybe you want to change it?

@IsakovAD
IsakovAD marked this pull request as ready for review March 28, 2022 11:15
@IsakovAD

IsakovAD commented Mar 28, 2022

Copy link
Copy Markdown
Contributor Author

One note, this PR will not be working without a new PR in QC (AliceO2Group/QualityControl#1115), so maybe we should wait with merging? I have changed the title to [WIP] to avoid merging.

@IsakovAD IsakovAD changed the title New ITS MC Track task [WIP] New ITS MC Track task Mar 28, 2022
@chiarazampolli

Copy link
Copy Markdown
Collaborator

If that is the case, indeed we should not merge it yet.

Chiara

@iravasen

Copy link
Copy Markdown
Contributor

@chiarazampolli / @knopers8 I enabled auto-merge for the QC PR (tests are almost done... last one running). Please merge this one by noon so that we have the task in the new suite. Thanks a lot!

@IsakovAD IsakovAD changed the title [WIP] New ITS MC Track task New ITS MC Track task Apr 7, 2022
@knopers8
knopers8 merged commit 5b2ae64 into AliceO2Group:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants