Do not get B field from external file anymore, but from CCDB - O2DPG - #977
Merged
Conversation
chiarazampolli
requested review from
davidrohr,
martenole and
shahor02
as code owners
March 28, 2023 11:23
chiarazampolli
changed the title
chiarazampolli
changed the title
chiarazampolli
changed the title
Contributor
|
I think it should be fine but I am wondering about the json files for MC and the json files used for tests of PR builds (located in the sync QC json folder). They should be also updated, right? (and as you mentioned also in Consul once the PRs are deployed) |
Collaborator
Author
|
Hello @tomas-herman , |
chiarazampolli
force-pushed
the
geomCCDB
branch
from
March 29, 2023 07:45
662f573 to
b48db4b
Compare
chiarazampolli
requested review from
benedikt-voelkel,
gconesab and
sawenzel
as code owners
March 29, 2023 07:49
chiarazampolli
force-pushed
the
geomCCDB
branch
from
March 29, 2023 11:10
2ac9bbd to
e98721c
Compare
Comment on lines
+44
to
+52
| "grpGeomRequest" : { | ||
| "geomRequest": "Aligned", | ||
| "askGRPECS": "false", | ||
| "askGRPLHCIF": "false", | ||
| "askGRPMagField": "true", | ||
| "askMatLUT": "false", | ||
| "askTime": "false", | ||
| "askOnceAllButField": "false", | ||
| "needPropagatorD": "false" |
Contributor
There was a problem hiding this comment.
I assume that the Geometry Request which is here, should be added also to:
- https://github.com/AliceO2Group/O2DPG/blob/master/DATA/production/qc-sync/mft-full.json
- https://github.com/AliceO2Group/O2DPG/blob/master/DATA/production/qc-sync/mft-full-no-tracks.json
- https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/QC/json/mft-clusters.json
I will try to do a local test but I need to rebuild as I have old versions of the SW,
rmunzer
pushed a commit
to rmunzer/O2DPG
that referenced
this pull request
Aug 8, 2023
…liceO2Group#977) * Do not get B field from external file anymore, but from CCDB * Also for TOF * Including ITS and MFT * For MC too * more MFT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@knopers8 , @shahor02 , goes with
AliceO2Group/AliceO2#11044
AliceO2Group/QualityControl#1692