Skip to content

PWGHF: Update Xic task#1012

Merged
vkucera merged 6 commits into
AliceO2Group:masterfrom
JinjooSeo:XicTask
Jul 22, 2022
Merged

PWGHF: Update Xic task#1012
vkucera merged 6 commits into
AliceO2Group:masterfrom
JinjooSeo:XicTask

Conversation

@JinjooSeo

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread PWGHF/Tasks/taskXic.cxx Outdated
Comment thread PWGHF/Tasks/taskXic.cxx Outdated

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make a PR in the Run3 validation repository to update the configuration.

Comment thread PWGHF/Tasks/taskXic.cxx Outdated
Comment thread PWGHF/Tasks/taskXic.cxx Outdated
@vkucera
vkucera marked this pull request as ready for review July 21, 2022 09:18
@vkucera

vkucera commented Jul 21, 2022

Copy link
Copy Markdown
Collaborator

I think you can add your name on the list of authors. :-)

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 5ebf883 at 2022-07-21 12:10:

## sw/BUILD/Clang-latest/log
CMake Error at tools/clang/tools/clang-shlib/cmake_install.cmake:46 (file):
ninja: build stopped: subcommand failed.

Full log here.

@JinjooSeo

JinjooSeo commented Jul 22, 2022

Copy link
Copy Markdown
Contributor Author

Please also make a PR in the Run3 validation repository to update the configuration.

Hi Vit, I tried modifying the Run3 Validation, but I don't have any idea because I think I did not manage the configuration in Xic task. Can you point out what I should modify? Sorry for bothering your vacation.

@JinjooSeo

Copy link
Copy Markdown
Contributor Author

I think you can add your name on the list of authors. :-)

Thanks, I forgot this. This is done!

@vkucera

vkucera commented Jul 22, 2022

Copy link
Copy Markdown
Collaborator

Please also make a PR in the Run3 validation repository to update the configuration.

Hi Vit, I tried modifying the Run3 Validation, but I don't have any idea because I think I did not manage the configuration in Xic task. Can you point out what I should modify? Sorry for bothering your vacation.

Hi @JinjooSeo , you have to update the task-xic block in the JSON configuration. See https://github.com/AliceO2Group/Run3Analysisvalidation/blob/master/codeHF/dpl-config_run3.json#L931,L938
See the corresponding configuration in the dumped dpl-config.json in your output_o2/*/.

@vkucera
vkucera merged commit f378ef9 into AliceO2Group:master Jul 22, 2022
lbariogl pushed a commit to CF-tutorials/O2Physics that referenced this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants