Skip to content

Developments of data model and tasks for skimming and candidates creation in UD#1021

Merged
pbuehler merged 14 commits into
AliceO2Group:masterfrom
nburmaso:ud-skimming
Jul 21, 2022
Merged

Developments of data model and tasks for skimming and candidates creation in UD#1021
pbuehler merged 14 commits into
AliceO2Group:masterfrom
nburmaso:ud-skimming

Conversation

@nburmaso

Copy link
Copy Markdown
Contributor

Summary of changes:

  • Add data model for reduced tables in UD: collisions, MC information, central barrel and forward tracks
  • Add track skimming task for ambiguous tracks
  • Add task for candidates creation using skimmed ambiguous tracks
  • Merge tables from DGCandidates with new UDTables
  • Adapt DG tasks to UDTables (basically, matter of renaming)

@pbuehler

Copy link
Copy Markdown
Collaborator

On line 72 of UDTables.h it says:
using SkimmedMCParticle = UDMcParticles::iterator;

which should be changed to
using UDMCParticle = UDMcParticles::iterator;

@pbuehler

Copy link
Copy Markdown
Collaborator

I propose to make the names of the tasks UDCandidateCreator, UDTrackSkimmer, dimuonAnalysis, trackSkimmerQA more specific to distinguish them from (future) other UD related tasks. They should somehow include the terms, UPC, Fwd, .... Also instead of Creator use Producer.

@nburmaso

nburmaso commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

Hi @pbuehler. Thank you for your comments! I have fixed typos and naming according to your suggestions. I have also reworked analyzer task for dimuons and changed its name -- its name now is UPCCandidateAnalyzer, for consistency with your task. Please let me know if there are more issues.

Nazar

@pbuehler pbuehler marked this pull request as ready for review July 21, 2022 06:52
@pbuehler pbuehler enabled auto-merge (squash) July 21, 2022 07:40
@pbuehler pbuehler merged commit 3e7d20d into AliceO2Group:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants