Developments of data model and tasks for skimming and candidates creation in UD#1021
Merged
Conversation
…kimmer, rework dimuon analysis
…iforward candidates
… IDs and add global BCs to tracks
Collaborator
|
On line 72 of UDTables.h it says: which should be changed to |
Collaborator
|
I propose to make the names of the tasks UDCandidateCreator, UDTrackSkimmer, dimuonAnalysis, trackSkimmerQA more specific to distinguish them from (future) other UD related tasks. They should somehow include the terms, UPC, Fwd, .... Also instead of Creator use Producer. |
Contributor
Author
|
Hi @pbuehler. Thank you for your comments! I have fixed typos and naming according to your suggestions. I have also reworked analyzer task for dimuons and changed its name -- its name now is Nazar |
pbuehler
approved these changes
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes: