Skip to content

DPG: add the flag for the specific track selection#1022

Closed
zhangbiao-phy wants to merge 2 commits into
AliceO2Group:masterfrom
zhangbiao-phy:master
Closed

DPG: add the flag for the specific track selection#1022
zhangbiao-phy wants to merge 2 commits into
AliceO2Group:masterfrom
zhangbiao-phy:master

Conversation

@zhangbiao-phy

Copy link
Copy Markdown
Collaborator

No description provided.

mfaggin
mfaggin previously approved these changes Jul 19, 2022

@mfaggin mfaggin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njacazio I approve this PR so that the guys can profit of this commit already on tomorrow's tag. It looks good to me, but please look at it when you have time.

@mfaggin

mfaggin commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

@zhangbiao-phy fix the formatting issues and then I approve it

@njacazio

Copy link
Copy Markdown
Collaborator

Hi Mattia, I looked already, I'm not sure I like it, we need to change more if we want to be using soa::Filtered<TrackTableMC> const& tracks, now

@mfaggin

mfaggin commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

Hi Mattia, I looked already, I'm not sure I like it, we need to change more if we want to be using soa::Filtered<TrackTableMC> const& tracks, now

ah you are right, in the actual code we do not filter but we cut manually only when desired. We cannot accept this PR as it is, I think @njacazio is going to transalte it now

@zhangbiao-phy

Copy link
Copy Markdown
Collaborator Author

@zhangbiao-phy fix the formatting issues and then I approve it

Hi @mfaggin, Thanks a lot! Done!

@mfaggin

mfaggin commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

@zhangbiao-phy fix the formatting issues and then I approve it

Hi @mfaggin, Thanks a lot! Done!

thanks Biao, but indeed Nicolò is right, let's wait for his fix (he is working on it)

@zhangbiao-phy

Copy link
Copy Markdown
Collaborator Author

Hi @mfaggin and @njacazio, thanks

@zhangbiao-phy fix the formatting issues and then I approve it

Hi @mfaggin, Thanks a lot! Done!

thanks Biao, but indeed Nicolò is right, let's wait for his fix (he is working on it)

Thanks @mfaggin and @njacazio!

@njacazio

Copy link
Copy Markdown
Collaborator

I propose the following #1024 if you agree we follow this there, thanks Biao for implementing this, it was highly due

@mfaggin

mfaggin commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

I propose the following #1024 if you agree we follow this there, thanks Biao for implementing this, it was highly due

much better, if this works for @zhangbiao-phy it's definitely in line with the older version and better for us

@njacazio

Copy link
Copy Markdown
Collaborator

Handled in the other PR #1024

@njacazio njacazio closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants