Skip to content

PWGHF: Dplus-hadron pair tables added#1041

Merged
fcolamar merged 14 commits into
AliceO2Group:masterfrom
Simple-Shyam:master
Jul 28, 2022
Merged

PWGHF: Dplus-hadron pair tables added#1041
fcolamar merged 14 commits into
AliceO2Group:masterfrom
Simple-Shyam:master

Conversation

@Simple-Shyam

@Simple-Shyam Simple-Shyam commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Dplus-hadron pairs table added for Dplus-hadron correlation task.
I will also add the correlation task soon.

@Simple-Shyam Simple-Shyam changed the title Dplus-hadron pair tables added PWGHF: Dplus-hadron pair tables added Jul 21, 2022

@Simple-Shyam Simple-Shyam left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PWGHF: Dplus-hadron correlation tasks are committed.

@fcolamar fcolamar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shyam, I see that build seems to be stuck since several hours, not sure if it's expected, let's wait another bit anyway.
For the rest, for me the PR is fine, I had a review before committing it.
Fabio

@Simple-Shyam

Simple-Shyam commented Jul 22, 2022

Copy link
Copy Markdown
Contributor Author

Thank you. It looks stuck and you can see I also committed the task and other changes in CMakeLists.txt.

fcolamar
fcolamar previously approved these changes Jul 25, 2022
@alibuild

alibuild commented Jul 25, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 57e6c2d at 2022-07-26 08:07:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1041-slc7_x86-64/0/PWGHF/HFC/TableProducer/HFCorrelatorDplusHadrons.cxx:299:30: error: 'Y' is not a member of 'RecoDecay'
/sw/SOURCES/O2Physics/1041-slc7_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDplusHadrons.cxx:47:21: error: 'Phi' is not a member of 'RecoDecay'
ninja: build stopped: subcommand failed.

Full log here.

@fcolamar

Copy link
Copy Markdown
Collaborator

Hi Shyam, you should rename your Y method to y, and check also the other renamings done in RecoDecay.h with PR #872.
I assume that in your local tests you used a not up-do-date version of the software, and in particular of RecoDecay.h

@fcolamar fcolamar self-requested a review July 25, 2022 13:38
@Simple-Shyam

Copy link
Copy Markdown
Contributor Author

Hi Shyam, you should rename your Y method to y, and check also the other renamings done in RecoDecay.h with PR #872. I assume that in your local tests you used a not up-do-date version of the software, and in particular of RecoDecay.h

Ciao Fabio, Yes, I will fix it and commit again after update of software.

@Simple-Shyam Simple-Shyam left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for the compilation in recent version of software.

@fcolamar fcolamar merged commit 7fdc728 into AliceO2Group:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants