Femtoworld - Adding angular correlation analysis #1055
Merged
Merged
Conversation
zchochul
requested review from
alibuild,
jgrosseo,
saganatt and
victor-gonzalez
as code owners
Collaborator
|
You have to rebase your changes to the latest tag |
saganatt
reviewed
Jul 26, 2022
saganatt
reviewed
Jul 26, 2022
saganatt
reviewed
Jul 26, 2022
saganatt
reviewed
Jul 26, 2022
saganatt
reviewed
Jul 26, 2022
saganatt
reviewed
Jul 26, 2022
saganatt
reviewed
Jul 26, 2022
Commiting on behalf of Zuzanna who cannot now access the computer but we want to run on Hyperloop tomorrow.
saganatt
approved these changes
Jul 26, 2022
Collaborator
Comment on lines
+80
to
+81
| mPhiLow = (-(int)(phiBins / 4) + 0.5) * 2. * TMath::Pi() / phiBins; | ||
| mPhiHigh = 2 * TMath::Pi() + (-(int)(phiBins / 4) + 0.5) * 2. * TMath::Pi() / phiBins; |
Collaborator
There was a problem hiding this comment.
In O2 CommonConstants/MathConstants.h you have these constants defined if you want to use them
Comment on lines
+127
to
+132
| while (delta_phi < mPhiLow) { | ||
| delta_phi += PIT; | ||
| } | ||
| while (delta_phi > mPhiHigh) { | ||
| delta_phi -= PIT; | ||
| } |
Collaborator
There was a problem hiding this comment.
Same comment as above
| float mMassTwo = 0.f; ///< PDG mass of particle 2 | ||
| double mPhiLow; | ||
| double mPhiHigh; | ||
| static constexpr double PIT = 6.28318530717958623; |
Collaborator
There was a problem hiding this comment.
Same comment as above
victor-gonzalez
approved these changes
Jul 26, 2022
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
I approve it but have a look at my comments in case you want to address them in the next iteration
Collaborator
|
Thank you @victor-gonzalez ! We will let Zuzanna fix it tomorrow. |
lbariogl
pushed a commit
to CF-tutorials/O2Physics
that referenced
this pull request
Jul 28, 2022
* Ifndf fixed + added detadphi histograms * Update PWGCF/FemtoWorld/Core/FemtoWorldContainer.h * Stylistic nitpicks Commiting on behalf of Zuzanna who cannot now access the computer but we want to run on Hyperloop tomorrow. Co-authored-by: Maja Kabus <8majak8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.