Skip to content

DPG: add track selections and check plots, modify binning#1063

Merged
mfaggin merged 2 commits into
AliceO2Group:masterfrom
mfaggin:master
Jul 27, 2022
Merged

DPG: add track selections and check plots, modify binning#1063
mfaggin merged 2 commits into
AliceO2Group:masterfrom
mfaggin:master

Conversation

@mfaggin

@mfaggin mfaggin commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator
  • Track selection development: Mattia Faggin
  • Check plots and binning changes: Rosario Turrisi

DPG: add track selections and check plots, modify binning
70719c0 
 - Track selection development: Mattia Faggin
 - Check plots and binning changes: Rosario Turrisi
@mfaggin mfaggin mentioned this pull request Jul 27, 2022
Closed
@mfaggin mfaggin enabled auto-merge (squash) July 27, 2022 12:19
alibuild
alibuild approved these changes Jul 27, 2022
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mfaggin.

@mfaggin

mfaggin commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator Author

@rosarioturrisi here the merge between your and my developments

@mfaggin mfaggin requested a review from alibuild July 27, 2022 12:23
@mfaggin mfaggin disabled auto-merge July 27, 2022 12:23
@mfaggin mfaggin enabled auto-merge (squash) July 27, 2022 12:23
alibuild
alibuild approved these changes Jul 27, 2022
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mfaggin.

@alibuild

alibuild commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for e6a234b at 2022-07-27 14:48:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@rosarioturrisi

rosarioturrisi commented Jul 27, 2022 via email

Copy link
Copy Markdown
Contributor

@mfaggin mfaggin merged commit 95e2f2f into AliceO2Group:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@mario-krueger mario-krueger Awaiting requested review from mario-krueger
@njacazio njacazio Awaiting requested review from njacazio

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfaggin @alibuild @rosarioturrisi