Prototype version of Resonance Package#1073
Merged
Merged
Conversation
Collaborator
|
Great work, we can also try the new merging ! |
njacazio
previously approved these changes
Jul 28, 2022
njacazio
reviewed
Jul 28, 2022
| DECLARE_SOA_COLUMN(TPCNClsCrossedRows, tpcNClsCrossedRows, uint8_t); //! Number of TPC crossed rows | ||
| DECLARE_SOA_COLUMN(DcaXY, dcaXY, float); //! DCA_xy | ||
| DECLARE_SOA_COLUMN(DcaZ, dcaZ, float); //! DCA_z | ||
| DECLARE_SOA_COLUMN(X, x, float); //! x position of the track |
Collaborator
There was a problem hiding this comment.
This is a redefinition of https://github.com/AliceO2Group/AliceO2/blob/dev/Framework/Core/include/Framework/AnalysisDataModel.h#L98 you could consider avoid this duplication and use directly aod::X in your table
Collaborator
Author
There was a problem hiding this comment.
That's a reasonable suggestion. I'll update the table.
njacazio
reviewed
Jul 28, 2022
| resodaughter::TPCNClsCrossedRows, | ||
| resodaughter::DcaXY, | ||
| resodaughter::DcaZ, | ||
| resodaughter::X, |
Collaborator
There was a problem hiding this comment.
Here you could use aod::X
Collaborator
Author
There was a problem hiding this comment.
That's new for me. Thanks for letting me know!
njacazio
approved these changes
Jul 28, 2022
njacazio
left a comment
njacazio
left a comment
Collaborator
There was a problem hiding this comment.
The new utility for the event cuts is super nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LFResonanceInitializerwill produce the dedicated table for RSN analysis.phianalysis.cxxis an example of this task.