Skip to content

Update binning policy class name to the new interface in new task in PWGLF#1110

Merged
BongHwi merged 2 commits into
AliceO2Group:masterfrom
saganatt:update-binning
Aug 16, 2022
Merged

Update binning policy class name to the new interface in new task in PWGLF#1110
BongHwi merged 2 commits into
AliceO2Group:masterfrom
saganatt:update-binning

Conversation

@saganatt

@saganatt saganatt commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

Hello @BongHwi ,

recently in July I extended the mixing interface with a new binning policy type. Therefore, I will keep ColumnBinningPolicy and FlexibleBinningPolicy as precise names, and with AliceO2Group/AliceO2#9528 I will remove the general BinningPolicy alias to avoid future confusions. Please let me update your code and follow with my O2 PR.

FYI, there is an up-to-date event mixing documentation at https://aliceo2group.github.io/analysis-framework/docs/framework/eventMixing.html which I update after any major change.

@alibuild

alibuild commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 032061c at 2022-08-08 17:32:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1110-slc7_x86-64/0/PWGLF/Tasks/phianalysis.cxx:109:5: error: 'ColumBinningPolicy' was not declared in this scope
/sw/SOURCES/O2Physics/1110-slc7_x86-64/0/PWGLF/Tasks/phianalysis.cxx:109:44: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/1110-slc7_x86-64/0/PWGLF/Tasks/phianalysis.cxx:109:73: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/1110-slc7_x86-64/0/PWGLF/Tasks/phianalysis.cxx:109:75: error: 'colBinning' was not declared in this scope
/sw/SOURCES/O2Physics/1110-slc7_x86-64/0/PWGLF/Tasks/phianalysis.cxx:137:97: error: expression list treated as compound expression in functional cast [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 10, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c4fe178 at 2022-08-11 01:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1110-slc7_x86-64/0/Common/TableProducer/PID/pidTOFBase.cxx:382:13: error: 'struct o2::framework::AxisSpec' has no member named 'makeLogarithmic'; did you mean 'makeLogaritmic'?
/sw/SOURCES/O2Physics/1110-slc7_x86-64/0/Common/TableProducer/PID/pidTOFBase.cxx:383:14: error: 'struct o2::framework::AxisSpec' has no member named 'makeLogarithmic'; did you mean 'makeLogaritmic'?
ninja: build stopped: subcommand failed.

Full log here.

@BongHwi

BongHwi commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

Hi @saganatt,
Thanks for the update!
+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants