Update binning policy class name to the new interface in new task in PWGLF#1110
Merged
Conversation
Collaborator
|
Error while checking build/O2Physics/o2 for 032061c at 2022-08-08 17:32: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for c4fe178 at 2022-08-11 01:45: Full log here. |
Collaborator
|
Hi @saganatt, |
BongHwi
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @BongHwi ,
recently in July I extended the mixing interface with a new binning policy type. Therefore, I will keep
ColumnBinningPolicyandFlexibleBinningPolicyas precise names, and with AliceO2Group/AliceO2#9528 I will remove the generalBinningPolicyalias to avoid future confusions. Please let me update your code and follow with my O2 PR.FYI, there is an up-to-date event mixing documentation at https://aliceo2group.github.io/analysis-framework/docs/framework/eventMixing.html which I update after any major change.