Skip to content

[Tools] Fix C++ issues#12028

Merged
ktf merged 2 commits into
AliceO2Group:masterfrom
vkucera:cppcheck-tools
Jul 14, 2025
Merged

[Tools] Fix C++ issues#12028
ktf merged 2 commits into
AliceO2Group:masterfrom
vkucera:cppcheck-tools

Conversation

@vkucera

@vkucera vkucera commented Jul 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Fix bugs:
    • Parameter ... can be declared as (reference to) const. (cppcheck)
    • Member variable ... is not initialized in the constructor. (cppcheck)
      • PidONNXModel::mPid
      • PidONNXModel::mMinCertainty
      • PidONNXInterface::mNPids
    • Expression is always true because 'else if' condition is opposite to previous condition. (cppcheck)
  • Fix includes:
    • IWYU (clang-tidy)
    • Include external headers with <>. (manual)
    • Sort includes. (clang-format)

@github-actions

github-actions Bot commented Jul 11, 2025

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@vkucera vkucera changed the title Fix C++ issues [Tools] Fix C++ issues Jul 11, 2025
@vkucera
vkucera marked this pull request as ready for review July 11, 2025 19:11
@ktf
ktf merged commit b4e8f5c into AliceO2Group:master Jul 14, 2025
18 checks passed
@saganatt

saganatt commented Jul 14, 2025

Copy link
Copy Markdown
Collaborator

Thank you, @vkucera and @ktf !

FYI @mytkom

@vkucera
vkucera deleted the cppcheck-tools branch July 14, 2025 09:15
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@vkucera @jpxrk
[Tools] Fix C++ issues (AliceO2Group#12028)
457cfb9
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@vkucera
[Tools] Fix C++ issues (AliceO2Group#12028)
944635f
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@vkucera
[Tools] Fix C++ issues (AliceO2Group#12028)
9250a76
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@vkucera @vojmach
[Tools] Fix C++ issues (AliceO2Group#12028)
1439df7
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@vkucera @jloemker
[Tools] Fix C++ issues (AliceO2Group#12028)
e59d3b3
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@vkucera
[Tools] Fix C++ issues (AliceO2Group#12028)
0bf6642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@saganatt saganatt Awaiting requested review from saganatt saganatt is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkucera @saganatt @ktf