[PWGDQ] Update dqEfficiency_withAssoc.cxx with 2 missing lines for efficienc…#13224
Closed
shreyasiacharya wants to merge 3 commits into
Closed
[PWGDQ] Update dqEfficiency_withAssoc.cxx with 2 missing lines for efficienc…#13224shreyasiacharya wants to merge 3 commits into
shreyasiacharya wants to merge 3 commits into
Conversation
shreyasiacharya
requested review from
alibuild,
iarsene,
lucamicheletti93 and
mcoquet642
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 312 errors, |
Collaborator
|
@shreyasiacharya Please do not open PRs as "ready for review" which do not compile and fail other required checks. |
Please consider the following formatting changes to #13224
Collaborator
|
Why did you mark it as "ready for review" again? Your PR does not compile. |
Collaborator
|
Error while checking build/O2Physics/o2 for 60de211 at 2025-10-04 11:45: Full log here. |
iarsene
reviewed
Oct 8, 2025
| Produces<aod::DileptonsInfo> dileptonInfoList; | ||
| Produces<aod::JPsieeCandidates> PromptNonPromptSepTable; | ||
| Produces<aod::OniaMCTruth> MCTruthTableEffi; | ||
| Produces<aod::OniaMCTruth>; |
Collaborator
There was a problem hiding this comment.
Why did you remove the name of the table to be produced?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y table