Skip to content

[Common] Fix problems found by Cppcheck #14178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddobrigk merged 13 commits into from
Jan 15, 2026
Merged

[Common] Fix problems found by Cppcheck #14178

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
de2fe06
pidTPCBase.h: Fix access out of bounds
vkucera Dec 11, 2025
0aec0ac
eventSelection.cxx: Fix type truncation
vkucera Dec 11, 2025
42f8b62
selectionStudyTable.cxx: Tag duplicate condition
vkucera Dec 11, 2025
da56cca
qaMuon.cxx: Rename shadow variables
vkucera Dec 11, 2025
8f1a453
EventSelectionModule.h: Rename shadow variables
vkucera Dec 11, 2025
c2f2d99
pidTPCModule.h: Fix pointer initialisation
vkucera Dec 11, 2025
10aab4d
pidTPCModule.h: Set correct severity for warnings
vkucera Dec 11, 2025
476dce6
pidTPCModule.h: Rename shadow variables
vkucera Dec 11, 2025
e3ba242
pidTPCModule.h: Fix access out of bounds
vkucera Dec 11, 2025
5305044
pidTPCModule.h: Add const
vkucera Dec 11, 2025
4d099b9
selectionStudyTable.cxx: Remove duplicated push_back
vkucera Dec 19, 2025
7c6766d
Merge remote-tracking branch 'upstream/master' into cppcheck-common
vkucera Jan 15, 2026
2578760
Merge remote-tracking branch 'upstream/master' into cppcheck-common
vkucera Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pidTPCModule.h: Rename shadow variables
  • Loading branch information
@vkucera
vkucera committed Dec 11, 2025
commit 476dce61ca8056b86e21297b8b6d2d974888fddb
10 changes: 5 additions & 5 deletions Common/Tools/PID/pidTPCModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ class pidTPCModule
constexpr int ExpectedInputDimensionsNNV3 = 8;
constexpr auto NetworkVersionV2 = "2";
constexpr auto NetworkVersionV3 = "3";
for (int i = 0; i < NParticleTypes; i++) { // Loop over particle number for which network correction is used
for (int j = 0; j < NParticleTypes; j++) { // Loop over particle number for which network correction is used
for (auto const& trk : tracks) {
if (!trk.hasTPC()) {
continue;
Expand All @@ -553,7 +553,7 @@ class pidTPCModule
track_properties[counter_track_props] = trk.tpcInnerParam();
track_properties[counter_track_props + 1] = trk.tgl();
track_properties[counter_track_props + 2] = trk.signed1Pt();
track_properties[counter_track_props + 3] = o2::track::pid_constants::sMasses[i];
track_properties[counter_track_props + 3] = o2::track::pid_constants::sMasses[j];
track_properties[counter_track_props + 4] = trk.has_collision() ? mults[trk.collisionId()] / 11000. : 1.;
track_properties[counter_track_props + 5] = std::sqrt(nNclNormalization / trk.tpcNClsFound());
if (input_dimensions == ExpectedInputDimensionsNNV2 && networkVersion == NetworkVersionV2) {
Expand Down Expand Up @@ -583,9 +583,9 @@ class pidTPCModule
float* output_network = network.evalModel(track_properties);
auto stop_network_eval = std::chrono::high_resolution_clock::now();
duration_network += std::chrono::duration<float, std::ratio<1, 1000000000>>(stop_network_eval - start_network_eval).count();
for (uint64_t i = 0; i < prediction_size; i += output_dimensions) {
for (int j = 0; j < output_dimensions; j++) {
network_prediction[i + j + prediction_size * loop_counter] = output_network[i + j];
for (uint64_t k = 0; k < prediction_size; k += output_dimensions) {
for (int l = 0; l < output_dimensions; l++) {
network_prediction[k + l + prediction_size * loop_counter] = output_network[k + l];
}
}

Expand Down