Skip to content

[PWGLF] Added mixed event v2 table for kstarpbpb task and optimize ev… - #17436

Draft
sarjeetagami wants to merge 4 commits into
AliceO2Group:masterfrom
sarjeetagami:master
Draft

[PWGLF] Added mixed event v2 table for kstarpbpb task and optimize ev…#17436
sarjeetagami wants to merge 4 commits into
AliceO2Group:masterfrom
sarjeetagami:master

Conversation

@sarjeetagami

@sarjeetagami sarjeetagami commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Added mixed event v2 table for kstarpbpb task and optimize event selection in phyanalysisrun3pbpb task

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Aug 12, 2026
Merged
@sarjeetagami
Merge pull request #1 from alibuild/alibot-cleanup-17436
8190348 
[PWGLF] Please consider the following formatting changes to AliceO2Group#17436
@sarjeetagami
sarjeetagami marked this pull request as ready for review August 12, 2026 15:34
@alibuild

alibuild commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8190348 at 2026-08-12 17:55:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 24 errors and 32 warnings.'
Found 24 errors and 32 warnings.
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/559c4c3a1cde218971f53d47a97a3d9e9f292d3a/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:29:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:49:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:90:42: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:353:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:405:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:438:12: error: variable 'pt1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:438:17: error: variable 'pt2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:438:22: error: variable 'pz1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:438:27: error: variable 'pz2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:438:32: error: variable 'p1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:438:36: error: variable 'p2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:438:40: error: variable 'angle' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:447:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:734:13: error: variable 'multiplicity' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:816:13: error: variable 'multiplicity' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:899:13: error: variable 'multiplicity' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:982:13: error: variable 'multiplicity' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:1233:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:1354:22: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:1483:13: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:1776:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:1992:13: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:2067:23: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:2142:23: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 32 -gt 0 ]]
++ cat /sw/BUILD/559c4c3a1cde218971f53d47a97a3d9e9f292d3a/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:137:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:140:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:142:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:144:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:146:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:148:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:150:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:159:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:196:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Resonances/kaDaughterProducer.cxx:202:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:373:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:376:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:379:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:382:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:385:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:388:103: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@sarjeetagami
sarjeetagami marked this pull request as draft August 13, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarjeetagami @alibuild