Skip to content

PWGHF: Add processData and origin flags in treeCreatorD0ToKPi#2229

Merged
vkucera merged 16 commits into
AliceO2Group:masterfrom
atavirag:different-tree-d0
Mar 21, 2023
Merged

PWGHF: Add processData and origin flags in treeCreatorD0ToKPi#2229
vkucera merged 16 commits into
AliceO2Group:masterfrom
atavirag:different-tree-d0

Conversation

@atavirag

@atavirag atavirag commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

I have added flags to distinguish between prompt and non-prompt D0s, and separated between processMC and processData using a PROCESS_SWITCH, so that it can be used on data as well.
Related PR: AliceO2Group/Run3AnalysisValidation#404

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atavirag , please fix the following problems:

Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
@atavirag

Copy link
Copy Markdown
Contributor Author

Hi, I am not sure what "clang-format" is asking me to change. I have tried changing the capitalization of acronyms, so that they follow the naming conventions from the documentation, but I still get an error. Do you have any idea what it could be?
Thank you!

@atavirag

Copy link
Copy Markdown
Contributor Author

Hi @vkucera, would these changes be okay?

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atavirag , please see further comments.

Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
@vkucera

vkucera commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

Add yourself on the list of authors.

@vkucera

vkucera commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

The PR title is too vague. Make it more descriptive.

@atavirag atavirag changed the title PWGHF: Change of treeCreatorD0toKPi.cxx PWGHF: Addition of processData and origin flags on treeCreatorD0toKPi.cxx Mar 17, 2023
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
@atavirag

Copy link
Copy Markdown
Contributor Author

I think it is all changed @vkucera

Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx
Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
@atavirag

Copy link
Copy Markdown
Contributor Author

I just added the changes, sorry for the delay @vkucera

Comment thread PWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atavirag . Please propagate the configuration changes in the validation framework.

@atavirag

Copy link
Copy Markdown
Contributor Author

I had a look, and I think there are no changes to be made in the validation framework, because the tree creator does not seem to be called.

@vkucera

vkucera commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

I had a look, and I think there are no changes to be made in the validation framework, because the tree creator does not seem to be called.

What do you mean by "does not seem to be called"? The JSON configuration needs to be updates with the process switches.

@vkucera vkucera changed the title PWGHF: Addition of processData and origin flags on treeCreatorD0toKPi.cxx PWGHF: Add processData and origin flags in treeCreatorD0toKPi Mar 21, 2023
@vkucera vkucera changed the title PWGHF: Add processData and origin flags in treeCreatorD0toKPi PWGHF: Add processData and origin flags in treeCreatorD0ToKPi Mar 21, 2023
@vkucera vkucera merged commit f17ac5f into AliceO2Group:master Mar 21, 2023
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Apr 3, 2023
zchochul pushed a commit to zchochul/O2Physics that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants