PWGCF: Updating event selection cuts - #4357
Merged
Merged
Conversation
SwatiSaha-1997
requested review from
alibuild,
jgrosseo,
saganatt,
victor-gonzalez and
zchochul
as code owners
January 17, 2024 21:25
SwatiSaha-1997
changed the title
Comment on lines
61
to
+69
| Configurable<float> cfgCutVertex{"cfgCutVertex", 10.0f, "Accepted z-vertex range"}; | ||
| Configurable<float> cfgCutPtLower{"cfgCutPtLower", 0.2f, "Lower pT cut"}; | ||
| Configurable<float> cfgCutPtUpper{"cfgCutPtUpper", 3.0f, "Higher pT cut"}; | ||
| Configurable<float> cfgCutTpcChi2NCl{"cfgCutTpcChi2NCl", 2.5f, "Maximum TPCchi2NCl"}; | ||
| // Configurable<float> cfgCutTrackDcaXY{"cfgCutTrackDcaXY", 0.1f, "Maximum DcaXY"}; | ||
| // Configurable<float> cfgCutTrackDcaXY{"cfgCutTrackDcaXY", 0.2f, "Maximum DcaXY"}; | ||
| Configurable<float> cfgCutTrackDcaZ{"cfgCutTrackDcaZ", 2.0f, "Maximum DcaZ"}; | ||
| ConfigurableAxis nchAxis{"nchAxis", {5000, 0.5, 5000.5}, ""}; | ||
|
|
||
| O2_DEFINE_CONFIGURABLE(cfgUse22sEventCut, bool, true, "Use 22s event cut on mult correlations") |
Collaborator
There was a problem hiding this comment.
I would recommend to, at some point, unify the way configurables are defined
Collaborator
Author
There was a problem hiding this comment.
Dear Victor, Thank you for your suggestions. I will update this in my next commit.
victor-gonzalez
approved these changes
Jan 18, 2024
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Have a look at my comment
rspijkers
pushed a commit
to rspijkers/O2Physics
that referenced
this pull request
Jan 19, 2024
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Feb 1, 2024
basiach
pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
ercolessi
pushed a commit
to ercolessi/O2Physics
that referenced
this pull request
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.