support for randomization via Fisher-Yates algorithm - #4360
Merged
Conversation
abilandz
requested review from
alibuild,
jgrosseo,
saganatt,
victor-gonzalez and
zchochul
as code owners
January 18, 2024 11:11
| if (tc.fRandomIndices) { | ||
| LOGF(fatal, "in function \033[1;31m%s at line %d\033[0m", __PRETTY_FUNCTION__, __LINE__); | ||
| } | ||
| this->RandomIndices(tracks.size()); |
Collaborator
There was a problem hiding this comment.
this is redundant, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, but it's a matter of taste - I like to use it to indicate that I am calling a member function directly implemented in a given class, and not inherited. It's not a very strong argument, I know...
victor-gonzalez
approved these changes
Jan 18, 2024
rspijkers
pushed a commit
to rspijkers/O2Physics
that referenced
this pull request
Jan 19, 2024
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Feb 1, 2024
basiach
pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
ercolessi
pushed a commit
to ercolessi/O2Physics
that referenced
this pull request
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.