Meanptpid#4869
Conversation
sweta29singh
requested review from
jgrosseo,
saganatt,
victor-gonzalez and
zchochul
as code owners
|
You have to rebase your changes to the latest version of |
Dear Victor, Now I have passed all checks after rebasing changes. Thanks and Regards |
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, address my comment or provide some reasoning for the change in the name
| double massPr = TDatabasePDG::Instance()->GetParticle(2212)->Mass(); | ||
|
|
||
| // struct IdentifiedMeanPtFluctuations { | ||
| struct MeanpTFluct { |
There was a problem hiding this comment.
Why are you changing the name if you are doing identified particles mean pT fluctuations?
The name probably collides with the unidentified particles mean pT fluctuations. Isn't it?
There was a problem hiding this comment.
Why are you changing the name if you are doing identified particles mean pT fluctuations? The name probably collides with the unidentified particles mean pT fluctuations. Isn't it?
Sorry I did it by mistake. Actually I was copying a file whose name is MeanpTFluct to IdentifiedMeanPtFluctation.cxx because in my local machine i was running my task under the name MeanpTFluct.
It's a mistake from my side. I will change the name in the task.
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments
Thanks Victor for approving the PR. |
2 participants
Addition of some basic QA plots in the existing code