Add boolean to enable/disable TPC QA plots + add centralityVsNch QA plot#5123
Merged
Conversation
romainschotter
commented
Mar 12, 2024
romainschotter
commented
Collaborator
- Add boolean to enable/disable TPC QA plots
- Add centralityVsNch QA plot in real and MC data processing functions
romainschotter
requested review from
BongHwi,
ChiaraDeMartin95,
alibuild,
chiarapinto,
ercolessi,
fmazzasc,
mbombara,
njacazio and
skundu692
as code owners
ddobrigk
reviewed
Mar 12, 2024
|
|
||
| // TOF PID | ||
| // Positive track | ||
| if (fabs(v0.posTOFDeltaTLaPr()) < maxDeltaTimeProton) |
Collaborator
There was a problem hiding this comment.
Hi @romainschotter, is this not equivalent to the preceding block? Or maybe I am missing something?... sorry if so!
| histos.add("AntiLambda/h3dNegNsigmaTPCvsTrackPt", "h3dNegNsigmaTPCvsTrackPt", kTH3F, {axisCentrality, axisPtCoarse, axisNsigmaTPC}); | ||
| histos.add("AntiLambda/h3dPosTPCsignalVsTrackPt", "h3dPosTPCsignalVsTrackPt", kTH3F, {axisCentrality, axisPtCoarse, axisTPCsignal}); | ||
| histos.add("AntiLambda/h3dNegTPCsignalVsTrackPt", "h3dNegTPCsignalVsTrackPt", kTH3F, {axisCentrality, axisPtCoarse, axisTPCsignal}); | ||
| if (doTPCQA) { |
Collaborator
There was a problem hiding this comment.
You should add an if(doTPCQA) statement also to the filling of the histograms (line 610 and others) or the task will crash due to histograms not found... can you please adjust? Thanks!
njacazio
approved these changes
Mar 13, 2024
Collaborator
|
I will wait for @romainschotter to comment on the status of the changes before merging |
Collaborator
Author
|
@njacazio you can go ahead and start merging. I have fixed the issues raised by David. Thank you very much! |
wuctlby
pushed a commit
to wuctlby/O2Physics
that referenced
this pull request
Mar 17, 2024
…lot (AliceO2Group#5123) * Megalinter again * Megalinter again v2 * Add TOF selections + fix generated candidates loop * Fix whitespaces * Add boolean to enable/disable TPC QA plots + add centralityVsNch QA plot * Fix clang and whitespaces * Remove duplicated checks + enable/disable TPC QA plots filling
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
…lot (AliceO2Group#5123) * Megalinter again * Megalinter again v2 * Add TOF selections + fix generated candidates loop * Fix whitespaces * Add boolean to enable/disable TPC QA plots + add centralityVsNch QA plot * Fix clang and whitespaces * Remove duplicated checks + enable/disable TPC QA plots filling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.