PWGCF: EbyE Intermittency analysis#5309
Conversation
maroozm
requested review from
alibuild,
jgrosseo,
saganatt,
victor-gonzalez and
zchochul
as code owners
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comments. Specially reconsider using derived data as your output data
| mHistArrReset[iPt * 40 + iM]->Fill(track.eta(), track.phi()); | ||
| mHistArrUReset[iPt * 40 + iM]->Fill(track.eta(), track.phi()); |
There was a problem hiding this comment.
There are 2*40 histograms storing exactly the same information
Is that what is intended?
There was a problem hiding this comment.
The ones that are reset per event mHistArrReset are needed (for QA, as they would have eta and phi for last event), but i can make mHistArrUReset optional.
There was a problem hiding this comment.
But then, storing the same information on 40 histograms is what is intended?
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my elaboration on the derived data sizes
maroozm
changed the title
maroozm
changed the title
firstcommit1 inprogress inprogress2 inprogress3 rebased_branch final_commit
|
Hi @victor-gonzalez, Regards, |
* firstcommit firstcommit1 inprogress inprogress2 inprogress3 rebased_branch final_commit * linter_fix * chgdimpl
* firstcommit firstcommit1 inprogress inprogress2 inprogress3 rebased_branch final_commit * linter_fix * chgdimpl
2 participants
Uh oh!
There was an error while loading. Please reload this page.