Skip to content

Full refactoring of O2Physics folder structure#54

Merged
jgrosseo merged 1 commit into
AliceO2Group:masterfrom
jgrosseo:master
Sep 2, 2021
Merged

Full refactoring of O2Physics folder structure#54
jgrosseo merged 1 commit into
AliceO2Group:masterfrom
jgrosseo:master

Conversation

@jgrosseo

@jgrosseo jgrosseo commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that trackUtilities.h was renamed to TrackUtilities.h which is not in line with the Coding guidelines:

Program file names and utility file names, which do not define a class or a namespace, start with a lower case letter.

myUtilities.h   // Utility functions/definitions
testMyClass.cxx // Test program

@jgrosseo

jgrosseo commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

I actually thought it was a typo...

@vkucera

vkucera commented Sep 2, 2021

Copy link
Copy Markdown
Collaborator

I actually thought it was a typo...

Now the diff shows that the renamed files were deleted. Could it be that you forgot git add them?

@jgrosseo

jgrosseo commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

The usual mess that git add -A is not picking up the same files as git commit -a...

Further reading: https://stevebennett.me/2012/02/24/10-things-i-hate-about-git/

@jgrosseo

jgrosseo commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

Apparently, it was green earlier. Merging.

@jgrosseo jgrosseo merged commit b2fc80a into AliceO2Group:master Sep 2, 2021
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request May 13, 2024
Please consider the following formatting changes to AliceO2Group#6097
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request May 8, 2025
[PWGCF] Please consider the following formatting changes to AliceO2Group#11114
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Jul 16, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Nov 19, 2025
[ALICE3] Please consider the following formatting changes to AliceO2Group#13845
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Jan 20, 2026
[PWGLF] Add QA histograms to track and generated daugh. particles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants