Update Run3 track selection#592
Merged
Merged
Conversation
njacazio
requested review from
a team,
alibuild,
iarsene,
jgrosseo and
ktf
as code owners
Member
|
good point, thanks! |
mario-krueger
previously approved these changes
Mar 8, 2022
Collaborator
Author
|
Hi @mario-krueger thanks, I mark it as ready for review |
Member
|
On second thought I would suspect however, that it does not change anything for the globalTrack selection, since there are other conditions which require hits in the ITS and clusters in the TPC. |
Collaborator
Author
|
I see. We need to investigate this issue as it seems that we get tracks that pass the global requirement that are TPC only so this triggered the change. I'm on it but probably there is no harm in merging this already |
Collaborator
Author
|
Hi @mario-krueger indeed I confirm that hasITS has an additional effect on the track selection wrt to the global cut |
Contributor
|
Isn't it misleading that this bypasses then the setting |
Collaborator
Author
|
@jgrosseo you are indeed right, I was hasty |
jgrosseo
approved these changes
Mar 8, 2022
robincaron13
pushed a commit
to robincaron13/O2Physics
that referenced
this pull request
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mario-krueger I think this should be needed to ask for real global tracks, what do you think?