fixed perpendicular cone calculation#6481
Merged
Merged
Conversation
alcaliva
requested review from
BongHwi,
ChiaraDeMartin95,
alibuild,
chiarapinto,
ercolessi,
fmazzasc,
mbombara,
njacazio and
skundu692
as code owners
ercolessi
approved these changes
Jun 11, 2024
GiorgioAlbertoLucia
pushed a commit
to GiorgioAlbertoLucia/O2Physics
that referenced
this pull request
Jul 9, 2024
echizzal
pushed a commit
to echizzal/O2Physics
that referenced
this pull request
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that using float for the vector components I had introduced a small quantization error that resulted in a non-zero rapidity shift between the jet axis and UE cone axis. Using double fixes the problem.
