flow measurement for identified particle in Pb-Pb collision#6489
Merged
Conversation
sdudi123
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
added 2 commits
June 12, 2024 14:25
Contributor
Author
|
Hello @saganatt , @zchochul and @victor-gonzalez |
victor-gonzalez
previously approved these changes
Jun 13, 2024
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
A lot of code is replicated. Replicating code is error prone and difficult to maintain
I approve it for the time being but I would suggest making extensive use of the template mechanism and common functions properly parameterized for avoiding as much as possible replicating code
Collaborator
|
@sdudi123 One of the source files you modified changed in the central repository |
victor-gonzalez
approved these changes
Jun 14, 2024
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
Don't forget my suggestions on reducing the amount of replicated code
GiorgioAlbertoLucia
pushed a commit
to GiorgioAlbertoLucia/O2Physics
that referenced
this pull request
Jul 9, 2024
…roup#6489) * flow measurement for identified particle in Pb-Pb collision using QCumulant method * flow measurement for identified particle in Pb-Pb collision using QCumulant method * bug is fixed --------- Co-authored-by: sandeep <sandeep@sandeeps-MacBook-Pro.local>
echizzal
pushed a commit
to echizzal/O2Physics
that referenced
this pull request
Jul 18, 2024
…roup#6489) * flow measurement for identified particle in Pb-Pb collision using QCumulant method * flow measurement for identified particle in Pb-Pb collision using QCumulant method * bug is fixed --------- Co-authored-by: sandeep <sandeep@sandeeps-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.