adding new 2trck cut#6522
Merged
Merged
Conversation
glromane
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
| res += sqrt(pow(2.0 * radius * sin(0.5 * GetPhiStarDiff(radius)), 2) + pow(2.0 * radius * sin(0.5 * dtheta), 2)); | ||
| } | ||
|
|
||
| return 100.0 * res / 9; |
Collaborator
There was a problem hiding this comment.
I would recommend using the length of the TPCradii instead of 9
Collaborator
Author
There was a problem hiding this comment.
Dear @victor-gonzalez , thank you your comment. The size is fixed so I used just 9, now I changed it to std::array and calling the size() method. Is it OK like this?
Collaborator
There was a problem hiding this comment.
Thanks! It is OK
My point was that if someone in the future changes the size of the array by including more radii they only need to care about the array and nothing else
Collaborator
Author
There was a problem hiding this comment.
ah, I see. Thanks!
victor-gonzalez
previously approved these changes
Jun 14, 2024
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Have a look at my comment
I approve it but I will wait for merging it in case you want to modify it
victor-gonzalez
approved these changes
Jun 14, 2024
GiorgioAlbertoLucia
pushed a commit
to GiorgioAlbertoLucia/O2Physics
that referenced
this pull request
Jul 9, 2024
* adding new 2trck cut * applying requisted change
echizzal
pushed a commit
to echizzal/O2Physics
that referenced
this pull request
Jul 18, 2024
* adding new 2trck cut * applying requisted change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @victor-gonzalez ,
in this commit we add a new double track cut. Could you please approve it. Thank you.
Sincerely yours, Gleb.