Skip to content

MegaLinter: Add missing step for artifact upload#6982

Merged
ddobrigk merged 1 commit into
AliceO2Group:masterfrom
vkucera:megalinter
Jul 30, 2024
Merged

MegaLinter: Add missing step for artifact upload#6982
ddobrigk merged 1 commit into
AliceO2Group:masterfrom
vkucera:megalinter

Conversation

@vkucera

@vkucera vkucera commented Jul 24, 2024

Copy link
Copy Markdown
Collaborator

MegaLinter does not create an automatic formatting PR if linters have found errors. The reported error messages are referring to lines in formatted files which can make it difficult to locate the corresponding lines in the committed files. See oxsecurity/megalinter#3399 Formatted files can be uploaded in artifacts, which gives the PR author the possibility to see which lines the linters complain about.

MegaLinter does not create an automatic formatting PR if linters have found errors.
The reported error messages are referring to lines in formatted files which can make it difficult to locate the corresponding lines in the committed files.
See oxsecurity/megalinter#3399
Formatted files can be uploaded in artifacts, which gives the PR author the possibility to see which lines the linters complain about.
@vkucera vkucera marked this pull request as ready for review July 24, 2024 20:57
@vkucera vkucera requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners July 24, 2024 20:57

@ddobrigk ddobrigk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ddobrigk ddobrigk merged commit 26f8585 into AliceO2Group:master Jul 30, 2024
@vkucera vkucera deleted the megalinter branch July 30, 2024 08:05
MaximVirta pushed a commit to MaximVirta/O2Physics that referenced this pull request Aug 5, 2024
MegaLinter does not create an automatic formatting PR if linters have found errors.
The reported error messages are referring to lines in formatted files which can make it difficult to locate the corresponding lines in the committed files.
See oxsecurity/megalinter#3399
Formatted files can be uploaded in artifacts, which gives the PR author the possibility to see which lines the linters complain about.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants