PWGCF: IdentifiedBF added PID for MC particles#8236
Merged
Conversation
bghanley1995
requested review from
alibuild,
ariedel-cern,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
October 30, 2024 13:34
Please consider the following formatting changes to AliceO2Group#8236
Contributor
Author
|
I'm confused what the MegaLinter error that occurred is. |
bghanley1995
changed the title
Comment on lines
1187
to
1189
| constexpr int pdgcodeEl = 11; | ||
| constexpr int pdgcodePi = 211; | ||
| constexpr int pdgcodeKa = 321; |
Collaborator
There was a problem hiding this comment.
I would suggest using named constants from TPDGCode.h (https://root.cern/doc/v632/TPDGCode_8h.html) for the next iteration
Contributor
Author
There was a problem hiding this comment.
Thank you Victor. I will do this for the next iteration.
victor-gonzalez
approved these changes
Oct 30, 2024
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Have a look at my comment
Collaborator
You can check under the |
victor-gonzalez
enabled auto-merge (squash)
October 30, 2024 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.