Skip to content

Enable time dependent response for TOF#874

Merged
iarsene merged 3 commits into
AliceO2Group:masterfrom
njacazio:nj-dpg-filtering
Jun 14, 2022
Merged

Enable time dependent response for TOF#874
iarsene merged 3 commits into
AliceO2Group:masterfrom
njacazio:nj-dpg-filtering

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

No description provided.

@njacazio njacazio requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners June 13, 2022 15:54
@njacazio

Copy link
Copy Markdown
Collaborator Author

This is transparent to the user, but needed to have a time dependent response. This is fetched only if the time dependent mode is enabled, and only if the current object is not valid anymore.

@njacazio

Copy link
Copy Markdown
Collaborator Author

As a further development we should have this handled centrally, however this can be merged as is

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for ba66fad at 2022-06-13 18:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/874-slc7_x86-64/0/Common/TableProducer/PID/pidTOF.cxx:190:49: error: 'class o2::ccdb::BasicCCDBManager' has no member named 'isCachedObjectValid'; did you mean 'struct o2::ccdb::CCDBManagerInstance::CachedObject'? (not accessible from this context)
/sw/SOURCES/O2Physics/874-slc7_x86-64/0/Common/TableProducer/PID/pidTOFFull.cxx:189:49: error: 'class o2::ccdb::BasicCCDBManager' has no member named 'isCachedObjectValid'; did you mean 'struct o2::ccdb::CCDBManagerInstance::CachedObject'? (not accessible from this context)
ninja: build stopped: subcommand failed.

Full log here.

@njacazio

Copy link
Copy Markdown
Collaborator Author

AliceO2Group/AliceO2#9165 needed for this to be working

iarsene
iarsene previously approved these changes Jun 14, 2022
@iarsene

iarsene commented Jun 14, 2022

Copy link
Copy Markdown
Collaborator

@njacazio, The o2 test crash seems genuine

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 9f4529f at 2022-06-14 12:59:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/874-slc7_x86-64/0/Common/TableProducer/PID/pidTOF.cxx:179:49: error: 'class o2::ccdb::BasicCCDBManager' has no member named 'isCachedObjectValid'; did you mean 'struct o2::ccdb::CCDBManagerInstance::CachedObject'? (not accessible from this context)
/sw/SOURCES/O2Physics/874-slc7_x86-64/0/Common/TableProducer/PID/pidTOFFull.cxx:178:49: error: 'class o2::ccdb::BasicCCDBManager' has no member named 'isCachedObjectValid'; did you mean 'struct o2::ccdb::CCDBManagerInstance::CachedObject'? (not accessible from this context)
ninja: build stopped: subcommand failed.

Full log here.

@iarsene iarsene merged commit 947f140 into AliceO2Group:master Jun 14, 2022
@njacazio njacazio deleted the nj-dpg-filtering branch June 14, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants