[PWGCF] LambdaR2Correlation Update#9076
Merged
victor-gonzalez merged 2 commits intoDec 20, 2024
Merged
Conversation
yashpatley
requested review from
alibuild,
ariedel-cern,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
| float retVal = 0.; | ||
|
|
||
| if (std::string(obj->ClassName()) == "TH1F") { | ||
| histos.fill(HIST("Tracks/h1f_tracks_info"), 21.5); |
Collaborator
There was a problem hiding this comment.
I would recommend to use an enum with named constants for the different tracks_info cases
If the corresponding histogram x axis starts with -0.5 the enum named constants can be used straight on
Additionally appropriate string labels can be used to identify each bin when shown
Contributor
Author
There was a problem hiding this comment.
Dear Victor, Thank you for this suggestion. I will try to update accordingly in next PR.
victor-gonzalez
approved these changes
Dec 20, 2024
victor-gonzalez
left a comment
victor-gonzalez
left a comment
Collaborator
There was a problem hiding this comment.
Have a look at my comment in case you want to consider it for further iterations
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.