Simplify TOF PID Response parameter usage#934
Merged
Conversation
Collaborator
Author
|
This PR simplifies the handling of the PID response, enabling in the meantime more features. This comes in parallel with a TOF parametrization fitted on the pilot beam data (already available on CCDB). Apologies for the long PR but this needs to be merged before the O2 can be changed and then O2Physics simplified. Ps. this should speedup the TOF PID |
1a47745 to
1eb8a5f
Compare
Collaborator
|
Error while checking build/O2Physics/o2 for 1eb8a5f at 2022-06-29 17:34: Full log here. |
7032985 to
332c2e6
Compare
iarsene
previously approved these changes
Jun 30, 2022
332c2e6 to
6474487
Compare
- bypass previous DetectorResponse common structure (will be removed) - New structure holds only parameters - Implementation is left in code only - Add additional param getter - Using data member as mass defined at compile time - Fix warning of overriding streamers - Simplify TOF param handler - Add performance plotting - Add validity based on run range - Add parameters to metadata - Add PID simple mode w/o slicing - Add possibility to turn on and off slices - Extend TOF PID tasks - Fix pidTOF switches - Update default par name to TOFResoParams, add FT0 only ev time - Clean includes - Extend TOF QA plots - Add ev time reso - Fill ev time per class - Align includes, fix ALICE3 TOF param
6474487 to
1e7e711
Compare
Collaborator
Author
|
Force pushing to retrigger CI tests |
jgrosseo
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bypass previous DetectorResponse common structure (will be removed)
New structure holds only parameters
Simplify TOF param handler
Add PID simple mode w/o slicing
Extend TOF PID tasks
Extend TOF QA plots