Skip to content

[PWGHF]: Fix search of mothers to work also at partonic level#939

Merged
vkucera merged 3 commits into
AliceO2Group:masterfrom
fgrosa:mcparticle
Jul 6, 2022
Merged

[PWGHF]: Fix search of mothers to work also at partonic level#939
vkucera merged 3 commits into
AliceO2Group:masterfrom
fgrosa:mcparticle

Conversation

@fgrosa

@fgrosa fgrosa commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator

This PR fixes the search of the mother particles, in particular when needed at partonic level (i.e. non-prompt tagging for HF analyses). In the previous version, only the first element of the mothers vector was checked, however most of the times the beauty quark is not in the first element. This was the origin of the issue related to the non-prompt tagging found in O2-2761, now fixed with this PR.

@fgrosa fgrosa changed the title [PWGH]: Fix search of mothers to work also at partonic level [PWGHF]: Fix search of mothers to work also at partonic level Jul 1, 2022
@vkucera

vkucera commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator

Please add the PWGHF: prefix in the commit title when your PR has only one commit as the PR title is ignored in such a case.

@vkucera

vkucera commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator

Thanks for the fix. Can you please add comments in the code to help understand how you use the new variables?

@fgrosa

fgrosa commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks for the fix. Can you please add comments in the code to help understand how you use the new variables?

Sure, I added them! Let me know if something is still unclear

@vkucera

vkucera commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator

Thanks for the fix. Can you please add comments in the code to help understand how you use the new variables?

Sure, I added them! Let me know if something is still unclear

Thanks

@vkucera

vkucera commented Jul 5, 2022

Copy link
Copy Markdown
Collaborator

@jgrosseo @iarsene It is fine with me to merge this.

@vkucera vkucera enabled auto-merge (squash) July 5, 2022 10:24
@fgrosa

fgrosa commented Jul 5, 2022

Copy link
Copy Markdown
Collaborator Author

@jgrosseo @iarsene It is fine with me to merge this.

Thanks @vkucera! I noticed now that the test on MacOs became red, but the error is unrelated to this PR, can we merge it anyway? It would be good to have it merged because the current version on Run3 MC productions leads to a wrong result

@vkucera

vkucera commented Jul 6, 2022

Copy link
Copy Markdown
Collaborator

All green. @jgrosseo @iarsene are you fine with approving?

@vkucera vkucera merged commit eeab638 into AliceO2Group:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants