Implement setter function to check MC signal from mother to daughter by feisenhu · Pull Request #945 · AliceO2Group/O2Physics

feisenhu · 2022-07-04T09:07:25Z

Implemented a setter function in the MCprong files to give the option, when defining a MCsignal in the MCSignalLibrary.h to check the MC signal from the mother to the daughter (In time).

Therefore the MC signal needs the mother pdg code as first entry and its daughter as second:
e.g.

  if (!nameStr.compare("LFQdecayToE")) {
    MCProng prong(2, {900, 11}, {true, true}, {false, false}, {0, 0}, {0, 0}, {false, false});
    prong.SetSignalInTime(0, true);                                                    // set direction to check for daughters (true, in time) or for mothers (false, back in time)
    signal = new MCSignal(name, "LF meson  + quarkonia decays into e", {prong}, {-1}); // pi0,eta,eta',rho,omega,phi,jpsi,psi2s mesons
    return signal;
  }

The CheckProng function in MCSignal.h then checks the boolean fCheckGenerationsInTime whether we have to check in the next generation for a mother or daughters.

If we look for daughters, we check if there is one, and if so if it has a pdg code of the next generation.
If it is true it uses the first daughter that fulfils that requirement and sets it as current particle to check for further generations.

(Note: There is no option currently to check multiple daughters in the same generation that would fulfil the MC signal.)

alibuild · 2022-07-04T09:44:34Z

Error while checking build/O2Physics/o2 for 7f828ff at 2022-07-04 11:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/945-slc7_x86-64/0/PWGDQ/Core/MCProng.h:102:21: error: 'MCProng::fUseANDonSourceBitMap' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/945-slc7_x86-64/0/PWGDQ/Core/MCProng.h:96:8: error:   'bool MCProng::fCheckGenerationsInTime' [-Werror=reorder]
/sw/SOURCES/O2Physics/945-slc7_x86-64/0/PWGDQ/Core/MCProng.cxx:52:1: error:   when initialized here [-Werror=reorder]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2022-07-04T12:14:12Z

Error while checking build/O2Physics/o2 for a31fd4f at 2022-07-04 14:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/945-slc7_x86-64/0/PWGDQ/Core/MCProng.h:102:21: error: 'MCProng::fUseANDonSourceBitMap' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/945-slc7_x86-64/0/PWGDQ/Core/MCProng.h:96:8: error:   'bool MCProng::fCheckGenerationsInTime' [-Werror=reorder]
/sw/SOURCES/O2Physics/945-slc7_x86-64/0/PWGDQ/Core/MCProng.cxx:52:1: error:   when initialized here [-Werror=reorder]
ninja: build stopped: subcommand failed.

Full log here.

iarsene · 2022-07-12T08:16:39Z

  void SetSources(int generation, uint64_t bits, uint64_t exclude = 0, bool useANDonSourceBits = true);
  void SetSourceBit(int generation, int sourceBit, bool exclude = false);
  void SetUseANDonSourceBits(int generation, bool option = true);
+  void SetSignalInTime(int generation, bool intime = false); // set variable to check generations in time or back in time (default)


This function does not need the first parameter (generation), since the rule to go back in time or in time, holds for the entire prong. So please remove it, only the "intime" parameter is used

iarsene · 2022-07-12T08:17:33Z

 }

+//________________________________________________________________________________________________________________
+void MCProng::SetSignalInTime(int generation, bool intime /*=false*/)


The "generation" parameter is not needed since the "intime" holds for the whole prong history

iarsene · 2022-07-12T08:17:46Z

+  if (generation < 0 || generation >= fNGenerations) {
+    return;
+  }


these lines can be removed

iarsene · 2022-07-12T08:19:37Z

+        // currentMCParticle = currentMCParticle.template mother0_as<U>();
+      }
+    } else {
+      // make sure that a daughter exists in the stack before moving one generation younger


Please add a comment here, mentioning that the prong history will move on the branch of the first daughter that matches the PDG requirement

iarsene · 2022-07-12T08:22:38Z

+          if (abs(d.pdgCode()) == fProngs[i].fPDGcodes[j + 1]) {
+            currentMCParticle = d;
+            break;


Here you check the absolute of the PDG code, however, the user has the option to choose between checking both charges (using the abs of the PDG code), or not. So the latter situation is overwritten here. Could you fix it? Ideally one should use here the MCProng::TestPDG() since that will take into account automatically these options.

iarsene · 2022-07-12T08:22:57Z

+            if (abs(d.pdgCode()) == fProngs[i].fPDGcodes[j + 1]) {
+              currentMCParticle = d;
+              break;


same comment as above

feisenhu · 2022-07-12T12:29:32Z

@iarsene
Tank you for your feedback.
I have included your comments:

removed the generation parameter in the SetSignalInTime() function
added a comment for the else {} case, to point out that branch is changing to daughter prong which fulfils the pdg requirement first
using the TestPDG() function to check if the daughter PDG is in the next generation
I now use fProngs[i].TestPDG(j + 1, d.pdgCode()) to check that daughter has correct pdg code.

In case there is something else that I should change please let me know.
kind regards

iarsene · 2022-07-13T05:52:00Z

+        if (currentMCParticle.has_daughters() && j < fProngs[i].fNGenerations - 1) {
+          // currentMCParticle = currentMCParticle.template mothers_first_as<U>();
+          // currentMCParticle = mcStack.iteratorAt(currentMCParticle.mothersIds()[0]);
+        }


This if statement doesn't do anything, should be removed

iarsene · 2022-07-13T05:53:33Z

Hi @feisenhu,
Thanks for the changes. There is just a small issue i still commented on, otherwise I am fine with the changes.

feisenhu · 2022-07-13T06:05:32Z

Hi @feisenhu,
Thanks for the changes. There is just a small issue i still commented on, otherwise I am fine with the changes.

You are right. Thank you for pointing out. :)
I have removed these lines.

feisenhu requested review from alibuild and iarsene as code owners July 4, 2022 09:07

feisenhu force-pushed the master branch 2 times, most recently from 8ed7b5d to 7f828ff Compare July 4, 2022 09:28

feisenhu force-pushed the master branch from 69173b4 to a31fd4f Compare July 4, 2022 10:44

iarsene reviewed Jul 12, 2022

View reviewed changes

feisenhu added 8 commits July 12, 2022 12:23

Implement option to check MCSignal in time and back in time

a7a5002

added some lines to pint MC signal to terminal

7be92dc

option to check MC from Mother to daugther, sucessfull

89e46f0

select mothers by mother_first_as()

a83dbf0

checkout CMakeLists.txt, remove task from list

b2c8daa

Increase ClassDef(), and add MC signal

0a71e44

change order of variables, fix o2 compiling error

b59a4b8

Include comments

c0a1f61

feisenhu force-pushed the master branch from b2d46b1 to c0a1f61 Compare July 12, 2022 12:13

iarsene previously approved these changes Jul 13, 2022

View reviewed changes

remove empty if case

456b52a

feisenhu dismissed iarsene’s stale review via 456b52a July 13, 2022 06:02

iarsene approved these changes Jul 13, 2022

View reviewed changes

iarsene merged commit 454d86b into AliceO2Group:master Jul 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement setter function to check MC signal from mother to daughter#945

Implement setter function to check MC signal from mother to daughter#945
iarsene merged 9 commits into
AliceO2Group:masterfrom
feisenhu:master

feisenhu commented Jul 4, 2022 •

edited

Loading

Uh oh!

alibuild commented Jul 4, 2022

Uh oh!

alibuild commented Jul 4, 2022

Uh oh!

iarsene Jul 12, 2022

Uh oh!

iarsene Jul 12, 2022

Uh oh!

iarsene Jul 12, 2022

Uh oh!

iarsene Jul 12, 2022

Uh oh!

iarsene Jul 12, 2022

Uh oh!

iarsene Jul 12, 2022

Uh oh!

feisenhu commented Jul 12, 2022

Uh oh!

iarsene Jul 13, 2022

Uh oh!

iarsene commented Jul 13, 2022

Uh oh!

feisenhu commented Jul 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

feisenhu commented Jul 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jul 4, 2022

Uh oh!

alibuild commented Jul 4, 2022

Uh oh!

iarsene Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

iarsene Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

iarsene Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

iarsene Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

iarsene Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

iarsene Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

feisenhu commented Jul 12, 2022

Uh oh!

iarsene Jul 13, 2022

Choose a reason for hiding this comment

Uh oh!

iarsene commented Jul 13, 2022

Uh oh!

feisenhu commented Jul 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

feisenhu commented Jul 4, 2022 •

edited

Loading