[PWGHF] Add prompt and non-prompt plots for efficiencies#9478
Merged
apalasciano merged 3 commits intoJan 24, 2025
Conversation
atavirag
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
vkucera and
zhangbiao-phy
as code owners
apalasciano
requested changes
Jan 23, 2025
apalasciano
left a comment
apalasciano
left a comment
Collaborator
There was a problem hiding this comment.
Hello Andrea, only very minor comments
| DECLARE_SOA_COLUMN(YCand1, yCand1, float); //! Rapidity of first candidate | ||
| DECLARE_SOA_COLUMN(YCand2, yCand2, float); //! Rapidity of second candidate | ||
| DECLARE_SOA_COLUMN(PhiCand1, phiCand1, float); //! Rapidity of first candidate | ||
| DECLARE_SOA_COLUMN(PhiCand2, phiCand2, float); //! Rapidity of second candidate |
Collaborator
There was a problem hiding this comment.
Suggested change
| DECLARE_SOA_COLUMN(PhiCand2, phiCand2, float); //! Rapidity of second candidate | |
| DECLARE_SOA_COLUMN(PhiCand2, phiCand2, float); //! Azimuthal angle of second candidate |
| DECLARE_SOA_COLUMN(PtCand2, ptCand2, float); //! Transverse momentum of second candidate | ||
| DECLARE_SOA_COLUMN(YCand1, yCand1, float); //! Rapidity of first candidate | ||
| DECLARE_SOA_COLUMN(YCand2, yCand2, float); //! Rapidity of second candidate | ||
| DECLARE_SOA_COLUMN(PhiCand1, phiCand1, float); //! Rapidity of first candidate |
Collaborator
There was a problem hiding this comment.
Suggested change
| DECLARE_SOA_COLUMN(PhiCand1, phiCand1, float); //! Rapidity of first candidate | |
| DECLARE_SOA_COLUMN(PhiCand1, phiCand1, float); //! Azimuthal angle of first candidate |
Contributor
Author
There was a problem hiding this comment.
Ciao Antonio, I just made the changes, thanks!
apalasciano
approved these changes
Jan 23, 2025
Contributor
Author
|
Hi @apalasciano, can this PR be merged? Thank you! |
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.