You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just have a doubt regarding the output values of the checkCharmHadronOrigin function: they correspond to the hf_cand::OriginType enum, but are independently defined since the HF code should not be included in the common one. A possible solution to have it uniquely defined would be to move the hf_cand::OriginType enum in the Common code, or alternatively to move the method checkCharmHadronOrigin in the HF code (however it could also be useful for DQ, since it can be used to tag charmonia as well). @vkucera do you have suggestions?
Hi @fgrosa , thanks for this implementation. I agree that the output of checkCharmHadronOrigin and OriginType should be synced independently of the HF code. I would be fine with moving OriginType into RecoDecay. It should not change anything about the includes because RecoDecay.h is already included in HFSecondaryVertex.h. What do you think?
Hi @fgrosa , thanks for this implementation. I agree that the output of checkCharmHadronOrigin and OriginType should be synced independently of the HF code. I would be fine with moving OriginType into RecoDecay. It should not change anything about the includes because RecoDecay.h is already included in HFSecondaryVertex.h. What do you think?
Hi @vkucera, thanks for your feedback! Indeed I also think it's a good solution, so I implemented it in the last commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a specific method to tag prompt/non-prompt charm hadrons, as discussed in Nonprompt_tagging_fgrosa_2022Jul04.pdf.
I just have a doubt regarding the output values of the
checkCharmHadronOriginfunction: they correspond to thehf_cand::OriginTypeenum, but are independently defined since the HF code should not be included in the common one. A possible solution to have it uniquely defined would be to move thehf_cand::OriginTypeenum in the Common code, or alternatively to move the methodcheckCharmHadronOriginin the HF code (however it could also be useful for DQ, since it can be used to tag charmonia as well). @vkucera do you have suggestions?