Skip to content

[Common, PWGHF, Event Filtering] Implement specific method to tag prompt/nonprompt charm hadrons#966

Merged
iarsene merged 7 commits into
AliceO2Group:masterfrom
fgrosa:mcparticle
Jul 13, 2022
Merged

[Common, PWGHF, Event Filtering] Implement specific method to tag prompt/nonprompt charm hadrons#966
iarsene merged 7 commits into
AliceO2Group:masterfrom
fgrosa:mcparticle

Conversation

@fgrosa

@fgrosa fgrosa commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

This PR implements a specific method to tag prompt/non-prompt charm hadrons, as discussed in Nonprompt_tagging_fgrosa_2022Jul04.pdf.

I just have a doubt regarding the output values of the checkCharmHadronOrigin function: they correspond to the hf_cand::OriginType enum, but are independently defined since the HF code should not be included in the common one. A possible solution to have it uniquely defined would be to move the hf_cand::OriginType enum in the Common code, or alternatively to move the method checkCharmHadronOrigin in the HF code (however it could also be useful for DQ, since it can be used to tag charmonia as well). @vkucera do you have suggestions?

@vkucera

vkucera commented Jul 11, 2022

Copy link
Copy Markdown
Collaborator

Hi @fgrosa , thanks for this implementation. I agree that the output of checkCharmHadronOrigin and OriginType should be synced independently of the HF code. I would be fine with moving OriginType into RecoDecay. It should not change anything about the includes because RecoDecay.h is already included in HFSecondaryVertex.h. What do you think?

Comment thread Common/Core/RecoDecay.h Outdated
Comment thread Common/Core/RecoDecay.h Outdated
Comment thread EventFiltering/PWGHF/HFFilter.cxx Outdated
Comment thread Common/Core/RecoDecay.h Outdated
@fgrosa

fgrosa commented Jul 11, 2022

Copy link
Copy Markdown
Collaborator Author

Hi @fgrosa , thanks for this implementation. I agree that the output of checkCharmHadronOrigin and OriginType should be synced independently of the HF code. I would be fine with moving OriginType into RecoDecay. It should not change anything about the includes because RecoDecay.h is already included in HFSecondaryVertex.h. What do you think?

Hi @vkucera, thanks for your feedback! Indeed I also think it's a good solution, so I implemented it in the last commit.

Comment thread Common/Core/RecoDecay.h Outdated
Comment thread Common/Core/RecoDecay.h Outdated
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 909c7f0 at 2022-07-12 10:13:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGCF/TableProducer/cmake_install.cmake:76 (file):
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fgrosa

@fgrosa

fgrosa commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator Author

Since it is fine for @vkucera, @iarsene could you please approve it? Thanks a lot!

@iarsene iarsene merged commit 24e8974 into AliceO2Group:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants