Event mixing: Update binning policy, add example for binning with lambda by saganatt · Pull Request #973 · AliceO2Group/O2Physics

saganatt · 2022-07-09T18:36:30Z

No description provided.

alibuild · 2022-07-09T18:50:00Z

Error while checking build/O2Physics/o2 for 3ce888a at 2022-07-11 09:40:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/tracksCombinations.cxx:54:3: error: 'ColumnBinningPolicy' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/tracksCombinations.cxx:60:44: error: 'trackBinning' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/tracksCombinations.cxx:76:25: error: 'ColumnBinningPolicy' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/tracksCombinations.cxx:77:5: error: 'BinningType' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/tracksCombinations.cxx:81:44: error: 'colBinning' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:35:23: error: 'ColumnBinningPolicy' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:36:3: error: 'BinningType' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:37:43: error: 'BinningType' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:37:54: error: template argument 3 is invalid
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:37:54: error: template argument 5 is invalid
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:37:61: error: 'binningOnPositions' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:37:86: error: cannot convert '<brace-enclosed initializer list>' to 'int' in initialization
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:44:45: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:44:45: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:52:86: error: expression list treated as compound expression in functional cast [-fpermissive]
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:65:23: error: 'ColumnBinningPolicy' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:66:3: error: 'BinningType' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:67:50: error: 'BinningType' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:67:61: error: template argument 3 is invalid
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:67:61: error: template argument 5 is invalid
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:67:68: error: 'binningOnPositions' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:67:93: error: cannot convert '<brace-enclosed initializer list>' to 'int' in initialization
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:74:45: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:74:45: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixingValidation.cxx:82:86: error: expression list treated as compound expression in functional cast [-fpermissive]
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackV0.cxx:189:5: error: 'ColumnBinningPolicy' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackV0.cxx:189:45: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackV0.cxx:189:80: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackV0.cxx:189:82: error: 'colBinning' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackV0.cxx:206:98: error: expression list treated as compound expression in functional cast [-fpermissive]
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackTrack.cxx:97:3: error: 'ColumnBinningPolicy' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackTrack.cxx:154:59: error: 'colBinning' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackTrack.cxx:216:65: error: 'colBinning' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/PWGCF/FemtoDream/femtoDreamPairTaskTrackTrack.cxx:236:98: error: expression list treated as compound expression in functional cast [-fpermissive]
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:41:23: error: 'ColumnBinningPolicy' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:42:3: error: 'BinningType' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:43:46: error: 'BinningType' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:43:57: error: template argument 3 is invalid
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:43:57: error: template argument 5 is invalid
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:43:64: error: 'binningOnPositions' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:43:89: error: cannot convert '<brace-enclosed initializer list>' to 'int' in initialization
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:50:45: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:50:45: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:58:86: error: expression list treated as compound expression in functional cast [-fpermissive]
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:71:23: error: 'ColumnBinningPolicy' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:72:3: error: 'BinningType' does not name a type
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:79:48: error: 'BinningType' was not declared in this scope
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:79:59: error: template argument 3 is invalid
/sw/SOURCES/O2Physics/973-slc7_x86-64/0/Tutorials/src/eventMixing.cxx:79:59: error: template argument 5 is invalid

Full log here.

victor-gonzalez · 2022-07-10T10:01:58Z

Perhaps this line

#include "Framework/GroupSlicer.h"

is missing in the FemtoDream files?

saganatt · 2022-07-11T05:34:26Z

Hi Victor,
no, Group Slicer is no longer used in event mixing.
These errors result from checks on older O2 (before my last O2 PRs were merged yesterday), seems I should have waited one day before submitting this PR. Is it possible to run the checks again with a newer O2 build?

victor-gonzalez · 2022-07-11T07:21:21Z

Hi Maja!
I see
I guess one way of forcing the checks would be to rebase your O2Physics code to the latest version and push it again
All checks will be re-run

alibuild · 2022-07-11T07:42:35Z

Error while checking build/O2Physics/o2 for 3d89046 at 2022-07-12 14:27:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGLF/Tasks/cmake_install.cmake:388 (file):
ninja: build stopped: subcommand failed.

Full log here.

saganatt · 2022-07-11T08:10:56Z

Ah, still too early. The checks still are building nightly-20220709, we need 20220710 at least.

victor-gonzalez · 2022-07-11T08:56:44Z

A bit of patience :-)

saganatt · 2022-07-15T08:59:34Z

Hi @victor-gonzalez , can we merge this? :)
Thank you in advance!

@lbariogl @jgrosseo FYI, a minor change in the mixing interface.

jgrosseo · 2022-07-27T15:34:03Z

Hi Maja! I see I guess one way of forcing the checks would be to rebase your O2Physics code to the latest version and push it again All checks will be re-run

For reference: when the CI builders are idle, they recheck all failed PRs. So no action needed.

saganatt requested review from a team, alibuild, iarsene, jgrosseo, ktf and victor-gonzalez as code owners July 9, 2022 18:36

saganatt force-pushed the lambda-binning branch from 3ce888a to 3d89046 Compare July 11, 2022 07:41

saganatt added 8 commits July 14, 2022 10:01

Add example for lambda binning

73fdf52

Corrected a bit the definitions

a06ae94

Delete accidentaly saved .swp

6da25b1

Cleanup of the tutorial, everything working

b57b0f8

Adjust to new binning interface, add lambda example to mixing tutorial

70fe882

nitpick

9620aa8

Fix order of mixing axes in tutorial example

f0419b1

Remove leftover TODO

8da7255

saganatt force-pushed the lambda-binning branch from 3d89046 to 8da7255 Compare July 14, 2022 08:01

victor-gonzalez approved these changes Jul 16, 2022

View reviewed changes

victor-gonzalez enabled auto-merge (squash) July 16, 2022 08:55

ktf disabled auto-merge July 19, 2022 07:47

ktf merged commit a82b9b1 into AliceO2Group:master Jul 19, 2022

saganatt deleted the lambda-binning branch July 19, 2022 07:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Event mixing: Update binning policy, add example for binning with lambda#973

Event mixing: Update binning policy, add example for binning with lambda#973
ktf merged 8 commits into
AliceO2Group:masterfrom
saganatt:lambda-binning

saganatt commented Jul 9, 2022

Uh oh!

alibuild commented Jul 9, 2022 •

edited

Loading

Uh oh!

victor-gonzalez commented Jul 10, 2022

Uh oh!

saganatt commented Jul 11, 2022

Uh oh!

victor-gonzalez commented Jul 11, 2022

Uh oh!

alibuild commented Jul 11, 2022 •

edited

Loading

Uh oh!

saganatt commented Jul 11, 2022

Uh oh!

victor-gonzalez commented Jul 11, 2022

Uh oh!

saganatt commented Jul 15, 2022 •

edited

Loading

Uh oh!

jgrosseo commented Jul 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

saganatt commented Jul 9, 2022

Uh oh!

alibuild commented Jul 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victor-gonzalez commented Jul 10, 2022

Uh oh!

saganatt commented Jul 11, 2022

Uh oh!

victor-gonzalez commented Jul 11, 2022

Uh oh!

alibuild commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saganatt commented Jul 11, 2022

Uh oh!

victor-gonzalez commented Jul 11, 2022

Uh oh!

saganatt commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jgrosseo commented Jul 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

alibuild commented Jul 9, 2022 •

edited

Loading

alibuild commented Jul 11, 2022 •

edited

Loading

saganatt commented Jul 15, 2022 •

edited

Loading