MRRTF-202: QC for matched muon tracks - #1505
Conversation
13a7a9b to
417616d
Compare
| if (selectedTracks[ix]) { | ||
| rtracks.emplace_back(tracks[ix]); | ||
| } | ||
| } |
There was a problem hiding this comment.
that would be more efficient to pass the subspan of all the tracks in the ROF together with the selectedTracks vector to fillTrackPairHistos(...) and apply the selection there than coping the selected tracks in a new vector.
There was a problem hiding this comment.
I prefer to let @aphecetche comment about this one, since he wrote the original code.
There was a problem hiding this comment.
The idea was to get the fillXXX methods as simple as possible and thus only get them a span of tracks (as opposed to passing tracks and something else).
The ideal solution maybe would be to pass a pair of iterators to the fillXXX methods and let the iterators do the selection (and "hide" both the ROFs and the tracks container structure from the fill methods), but I thought that would be overkill.
Anyway, unless we have evidence that the creation of a new vector actually causes a performance problem, I would leave it as is for the moment.
The generic MuonTrack objects provides a generic interface for accessing the parameters of muon tracks regardless of their actual type (MCH-only, MCH+MCH or refitted MFT+MCH(+MID))
The plotter automatically creates and fills plots for the different matching combinations (MCH, MCH+MID, MFT+MCH, MFT+MCH+MID).
Reference configuration files for the different matching combinations are also included.
ad3af3d to
e529a0b
Compare
aferrero2707
changed the title
|
@aferrero2707 there's a genuine "compilation" error : Error in : I/O is supported only for unique_ptrs with a default deleter. o2::quality_control_modules::muon::TrackPlotter::mNofTracksPerTF appears to have a custom one, . |
|
@aphecetche interesting... I do not get this error when compiling on our development FLP with O2 stack. |
|
@Barthelemy @knopers8 this one is finalized and CI is all green. Would it be possible to merge it? Thanks! |
4 participants
No description provided.