This repository was archived by the owner on Dec 1, 2025. It is now read-only.
admin/loosen-any-non-zero-semver-deps#294
Merged
Merged
Conversation
AetherUnbound
approved these changes
Aug 9, 2021
toloudis
approved these changes
Aug 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 95.09% 94.90% -0.20%
==========================================
Files 35 35
Lines 2612 2612
==========================================
- Hits 2484 2479 -5
- Misses 128 133 +5
Continue to review full report at Codecov.
|
Contributor
|
Danke schön. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Got a ping from @joshmoore regarding
zarrversion conflicts posted on image.sc: https://forum.image.sc/t/incompatible-version-of-zarr-for-ome-zarr-and-aicsimageio/56152We can solve this and other future issues like it by loosening the version pins associated with non-version-zero-sem-ver deps (i.e. 0.x.x).
The format means:
~=a.banything greater than or equal toa.band less thana+1Pull request recommendations:
Tests are failing because #293 hasn't merged yet.
Thanks for contributing!