Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

admin/loosen-any-non-zero-semver-deps#294

Merged
evamaxfield merged 3 commits into
mainfrom
admin/loosen-any-non-zero-deps
Aug 9, 2021
Merged

admin/loosen-any-non-zero-semver-deps#294
evamaxfield merged 3 commits into
mainfrom
admin/loosen-any-non-zero-deps

Conversation

@evamaxfield

@evamaxfield evamaxfield commented Aug 9, 2021

Copy link
Copy Markdown
Collaborator

Description

Got a ping from @joshmoore regarding zarr version conflicts posted on image.sc: https://forum.image.sc/t/incompatible-version-of-zarr-for-ome-zarr-and-aicsimageio/56152

We can solve this and other future issues like it by loosening the version pins associated with non-version-zero-sem-ver deps (i.e. 0.x.x).

The format means: ~=a.b anything greater than or equal to a.b and less than a+1

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [Fix release #12], adds tiff file format support
  • Provide relevant tests for your feature or bug fix.

Tests are failing because #293 hasn't merged yet.

  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added the admin Various administrative tasks for the package label Aug 9, 2021
@evamaxfield evamaxfield self-assigned this Aug 9, 2021
@codecov-commenter

codecov-commenter commented Aug 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #294 (f57ebfb) into main (9e90ff4) will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   95.09%   94.90%   -0.20%     
==========================================
  Files          35       35              
  Lines        2612     2612              
==========================================
- Hits         2484     2479       -5     
- Misses        128      133       +5     
Impacted Files Coverage Δ
aicsimageio/tests/conftest.py 92.30% <0.00%> (-3.85%) ⬇️
aicsimageio/tests/readers/test_czi_reader.py 96.29% <0.00%> (-3.71%) ⬇️
aicsimageio/readers/ome_tiff_reader.py 96.94% <0.00%> (-0.77%) ⬇️
aicsimageio/readers/czi_reader.py 95.34% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e90ff4...f57ebfb. Read the comment docs.

@evamaxfield evamaxfield merged commit 41595cb into main Aug 9, 2021
@evamaxfield evamaxfield deleted the admin/loosen-any-non-zero-deps branch August 9, 2021 23:51
@joshmoore

Copy link
Copy Markdown
Contributor

Danke schön.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admin Various administrative tasks for the package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants