Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

feature/ome-metadata-in-save#300

Closed
evamaxfield wants to merge 7 commits into
mainfrom
feature/ome-metadata-with-save
Closed

feature/ome-metadata-in-save#300
evamaxfield wants to merge 7 commits into
mainfrom
feature/ome-metadata-with-save

Conversation

@evamaxfield

Copy link
Copy Markdown
Collaborator

Description

Adds a parameter to the AICSImage.save function that enables saving with metadata translation instead of basic metadata item retrieval.

Many bugs still remain.

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [Fix release #12], adds tiff file format support
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@codecov-commenter

codecov-commenter commented Aug 24, 2021

Copy link
Copy Markdown

Codecov Report

Merging #300 (c4ca414) into main (d372e0d) will decrease coverage by 0.18%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   94.34%   94.15%   -0.19%     
==========================================
  Files          44       44              
  Lines        3129     3149      +20     
==========================================
+ Hits         2952     2965      +13     
- Misses        177      184       +7     
Impacted Files Coverage Δ
aicsimageio/aics_image.py 88.57% <90.90%> (+0.08%) ⬆️
aicsimageio/tests/test_aics_image.py 100.00% <100.00%> (ø)
aicsimageio/tests/conftest.py 92.30% <0.00%> (-3.85%) ⬇️
aicsimageio/tests/readers/test_czi_reader.py 96.29% <0.00%> (-3.71%) ⬇️
aicsimageio/readers/ome_tiff_reader.py 98.13% <0.00%> (-0.94%) ⬇️
aicsimageio/readers/czi_reader.py 95.43% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d372e0d...c4ca414. Read the comment docs.

@evamaxfield evamaxfield force-pushed the feature/ome-metadata-with-save branch 2 times, most recently from 76f7f1c to f67b6a3 Compare August 24, 2021 17:18
@evamaxfield evamaxfield mentioned this pull request Sep 19, 2021
4 tasks
@SeanDuHare SeanDuHare deleted the feature/ome-metadata-with-save branch September 27, 2023 15:25
@SeanDuHare SeanDuHare restored the feature/ome-metadata-with-save branch September 27, 2023 15:25
@SeanDuHare SeanDuHare deleted the feature/ome-metadata-with-save branch October 30, 2023 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants