This repository was archived by the owner on Dec 1, 2025. It is now read-only.
docs/update-biofile-docstring-add-bf-options-param#322
Merged
Conversation
evamaxfield
approved these changes
Sep 27, 2021
evamaxfield
left a comment
Collaborator
There was a problem hiding this comment.
Perfect. Thanks!
Will wait for builds to pass then merge.
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 94.59% 94.30% -0.30%
==========================================
Files 40 40
Lines 3016 3018 +2
==========================================
- Hits 2853 2846 -7
- Misses 163 172 +9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just wanted to clarify the expected dimensions on the objects returned by the (lower level)
BioFile.to_numpyandto_dask. Also, rather than hardcode the'nativend2.chunkmap' = False, this just lets the user use any of the options declared here with the newoptionsparameter. Lastly, I added a few parameters (original_meta,memoize,options) to the mainBioformatsReader.__init__to expose some of the underlying options.Pull request recommendations:
Thanks for contributing!