Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

admin/remove-lif-from-standard-install#332

Merged
evamaxfield merged 4 commits into
mainfrom
admin/remove-lif-from-standard-install
Oct 8, 2021
Merged

admin/remove-lif-from-standard-install#332
evamaxfield merged 4 commits into
mainfrom
admin/remove-lif-from-standard-install

Conversation

@evamaxfield

@evamaxfield evamaxfield commented Oct 8, 2021

Copy link
Copy Markdown
Collaborator

Mirrors the GPL installation pattern changes from #329 but for readlif which is also under GPL.

Tagging @nimne and @psobolewskiPhD as I believe you two are heavy users of this LIF support and will need to change your install patterns.


Resolves #331

@evamaxfield evamaxfield added documentation Improvements or additions to documentation admin Various administrative tasks for the package labels Oct 8, 2021
@evamaxfield evamaxfield self-assigned this Oct 8, 2021
@psobolewskiPhD

Copy link
Copy Markdown
Contributor

Thanks for the heads up!
Should be no issue on my end.
❤️

@codecov-commenter

codecov-commenter commented Oct 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #332 (e75c5bb) into main (459e469) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   94.46%   94.30%   -0.17%     
==========================================
  Files          40       40              
  Lines        3018     3018              
==========================================
- Hits         2851     2846       -5     
- Misses        167      172       +5     
Impacted Files Coverage Δ
aicsimageio/readers/lif_reader.py 97.90% <ø> (ø)
aicsimageio/tests/conftest.py 92.30% <0.00%> (-3.85%) ⬇️
aicsimageio/tests/readers/test_czi_reader.py 96.29% <0.00%> (-3.71%) ⬇️
aicsimageio/readers/ome_tiff_reader.py 98.13% <0.00%> (-0.94%) ⬇️
aicsimageio/readers/czi_reader.py 95.43% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459e469...e75c5bb. Read the comment docs.

Comment thread README.md Outdated
@evamaxfield evamaxfield merged commit bd5fbac into main Oct 8, 2021
@evamaxfield evamaxfield deleted the admin/remove-lif-from-standard-install branch October 8, 2021 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admin Various administrative tasks for the package documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mirror installation pattern of bioformats_jar to readlif

6 participants