This repository was archived by the owner on Dec 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
feature/use-dask #63
Merged
Merged
feature/use-dask #63
Changes from all commits
Commits
Show all changes
103 commits
Select commit
Hold shift + click to select a range
9ec7ed7
Beginning work for converting the entire project over to dask
93877d2
Add function for get image data as da
3f5b749
Add basic file path checking to Reader base class init
a57dfd1
Finish default reader
d824771
Convert NdArrayReader to ArrayLikeReader to support both numpy and dask
319d607
Add imreada function to get back dask array
0d0bd32
Rename init param for ArrayLikeReader from arr to data
ffadb9d
Fix lazy load init with a todo for later
f20b746
Starting work on switching czi reader from vender czi file to pylibczi
7882abd
Fix typo in get_image_data_da function name
abfc8bd
Working czireader daread to dask array
be71c24
Create stable API by specifying functions as either dask or numpy
90e25c0
Fix already daskified readers dims property to use dask data
41d69fd
Add checks for task count after running basic reader operations
8f6b5c3
Include dask and toolz dependencies in setup
2234b71
Delayed dask CziReader and tests
3ebf3e5
Add comments to daread
ed7058f
Various file formatting
b095ec7
Add dask image dep for tiff reading
457517d
Remove dask image dep and add TiffFile upgrade dep
2819a29
Change internal czi scene holder parameter name
1e39796
Add checks for open files between basics and loaded
31064a8
Add delayed tiff reader and tests
1646cd2
Get rid of default reader dims setter
402b163
Add test case for checking that Y and X are always added to chunk dims
d104dff
Get rid of dims setter on arraylike reader
b75bc7d
Move _resolve_image_path to base class and run during init
2f48750
Reorder test asserts
973a077
Write better conflicting dimension sizes scene check in czi reader
78a78da
Add tests for resolve image path
1bd92e0
Add a bit of documentation on TiffReader
92f3bc3
Rewrite OmeTiffReader to use TiffReader as base
33ef395
Add tests for CziReader for get channel names
69feeb8
Add utf marker to test tiff reader
3de6681
Update transforms to allow either dask or numpy
8123d70
Update writer tests
3db18cf
Fix various linting errors and recursion error in aicsimage
839795c
Switch which element type is returned from czi metadata
99d461c
Get rid of inconsistant shape error
0e38bd0
Almost all tests passing, only tests failing rely on numpy function
534c5ae
Add dask multi-operator version of np.split to transforms
0863ba8
aicspylibczi is not supported on python 3.6
b989b7d
Move from warn to warning as warn is depricated
ec49c2d
Bug fixes for da cumsum
68347a2
Support tiffs with bad dimension labels by merging guess with valid dims
d65ee02
Check known dims kwarg on aicsimageio object during init for valid dims
e568252
Add test for reshaping data when provided dims that it doesn't have
4da0f36
Add dask interactive deps
f4fd6b2
Do not resolve paths because mounted drives are symlinked
8815020
Add dask cluster examples with various configurations
47bb32c
Fix non existing variable for is_this_type
4b5acfe
Remove extra get reader call on default reader
bfbebb8
Fix bug and add tests for variable per scene dims czi file
dea3df6
Remove Dimension B as it was unused
90e5f24
Add docstring to read image
562d3d6
Remove TypeError from CziReader failed scene selection
cbe47d1
Fix typo in comment
52ef679
Add log statement informing the user we default due to variable dims
58b3ab7
Remove _size_s as it isn't used
d3c83d8
Div points in transforms can always be numpy
c163dcd
Add doc format info to init files
e445749
Only return scene dimension if multiple scenes present in tiff
74377dd
Add back dims setters to chosen readers
c5889e7
Add back tiff dtype func and ome tiff is ome func
0983548
Fix how tiff dimensions are guessed
01be591
Update python requires until pylibczi has been released on 3.6
579ad54
Shuffle dependencies around
c29c906
Add shape property to AICSImage object
c27b61a
Add test for AICSImage.shape property
9da4d5c
Get rid of random S string in favour of Dimensions.Scene
65ce16f
Add view napari function
bf70a19
Use reader property instead of _reader in aicsimage calls
e4f9002
Add tests for napari and fix minor bugs
95a0a19
Add dtype function back to CziReader and add test
52e28e9
Add back various utility functions to CziReader and TiffReader
cb6f7b3
Change typing on OmeTiffReader is this type
709a1ae
Add dask cluster and client spawning during context manager
7651477
Add tests and fix bugs for dask client and cluster context manager
8fd1663
Rename dask utilities to have standard naming
f56fe95
Move around how the dask utils tests are run
e021055
Change the dask utils tests to simply mock the utility function
305fba0
Add back load slice function to tiff reader
a519f02
Add documentation
207ebdc
Remove aicsimageio planning image from README
46e68ae
Fix typo in README
15356f8
Update issue templates and workflows
0615d33
Convert tests to check for specific file rather than any open files
cc5722a
Change wordings in README
c01117c
Add back Python 3.6 builds
1757cbf
Add dask utils `cluster_and_client` context manager and update README
03ee29b
Fix README line break
4340196
Make "ArrayLike" type for np.ndarray and da.core.Array
c98861b
Unpack CZIReader dim info during items instead of inside loop
863234d
Catch any unsupported file format on DefaultReader and reraise
5175fa7
Break out of loop on first detection that tiff scenes are variable sizes
d74a799
Removed unused typing in transforms and arraylike reader
75dfaf5
Unpack TiffReader np index during enumerate instead of inside loop
b58fbdf
Move back to only supporting 3.7
c0b38da
Add a log statement informing the user that we guessed a Tiff dimension
0b11a3e
Resolves #69, Change context manager API to use dask_kwargs param
a6d27ea
Change reader is_this_type to use `_resolve_image_path`
083a006
No need to save values cluster and client in dask utils context mngr
e451ba3
Add back python 3.6 builds
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,35 @@ | ||
| **Description:** | ||
| A clear and concise description of what the bug is. | ||
| --- | ||
| name: Bug Report | ||
| about: '"Something''s wrong..."' | ||
| title: '' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| **Expected Behavior:** | ||
| A clear and concise description of what you expected to happen. | ||
| --- | ||
|
|
||
| **System and Software:** | ||
| ## System and Software | ||
| * aicsimageio Version: | ||
| * Python Version: | ||
| * Operating System: | ||
|
|
||
| **Steps to Reproduce:** | ||
| ``` | ||
| Paste the command(s) you used and the output. | ||
| ``` | ||
|
|
||
| **Additional context** | ||
| Add any other context about the problem here. | ||
| ## Description | ||
| *A clear description of the bug* | ||
|
|
||
|
|
||
|
|
||
|
|
||
| ## Expected Behavior | ||
| *What did you expect to happen instead?* | ||
|
|
||
|
|
||
|
|
||
|
|
||
| ## Reproduction | ||
| *A minimal example that exhibits the behavior.* | ||
|
|
||
|
|
||
|
|
||
|
|
||
| ## Environment | ||
| *Any additional information about your environment* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,23 @@ | ||
| **Description:** | ||
| A clear and concise description of what you want to happen. | ||
| --- | ||
| name: Feature Request | ||
| about: '"It would be really cool if x did y..."' | ||
| title: '' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| **Additional context** | ||
| Add any other context or screenshots about the feature request here. | ||
| --- | ||
|
|
||
| ## Use Case | ||
| *Please provide a use case to help us understand your request in context* | ||
|
|
||
|
|
||
|
|
||
|
|
||
| ## Solution | ||
| *Please describe your ideal solution* | ||
|
|
||
|
|
||
|
|
||
|
|
||
| ## Alternatives | ||
| *Please describe any alternatives you've considered, even if you've dismissed them* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,9 @@ instance/ | |
| docs/_build/ | ||
| docs/aicsimageio.*rst | ||
|
|
||
| # Dask workers | ||
| dask-worker-space/ | ||
|
|
||
| # PyBuilder | ||
| target/ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.