how to remove toastr dependency

[pocesar]

I'm not using or planning to using it, and it's adding react and react-dom @ 15.3.2, making my build at least 150kb bigger. plus it's breaking SystemJS import with multiple react versions

[garethdown44]

Same - it's causing 15.3.2 to be pulled in. react-toastr should be an opt-in dependency. All I want is a grid with sorting and paging, I don't need toasts.

[pocesar]

solved it in JSPM / SystemJS using the map / dependency overrides (might be similar to webpack)

"jspm": {
   "overrides": {
      "npm:@allenfang/react-toastr@2.8.2": {
        "dependencies": {
          "react": "^15.4.2",
          "react-dom": "^15.4.2",
          "react-addons-update": "^15.4.2",
          "classnames": "^2.2.5",
          "element-class": "^0.2.2",
          "lodash": "^4.17.0"
        },
        "map": {
          "./lib/ToastMessage": "./lib/ToastMessage/index",
          "react": "npm:react@15.4.2",
          "react-dom": "npm:react-dom@15.4.2",
          "react-addons-update": "npm:react-addons-update@15.4.2"
        }
      }
    }
  }
}

[AllenFang]

sorry for lately reply, I wanna drop it also, but it was deep dependency since a long time ago and even make some trouble by #838 #863

Actually, I will spend some time to separate it but not now, so PR is welcome, maybe the worst solution I may need to separate two repo or event bundle two files.

[pocesar]

the roastr dependency SEEMS to work fine with React 15.4.2, the only problem is that the path to ReactDOM is wrong, it doesn't exist in react/lib/ReactDOM anymore but in react-dom dependency itself. the mappings hack did fix it, SystemJS is able to remap the dependency at will, but the proper way would be to remove the dependency on react / react-dom on roastr itself

when build systems like SystemJS load 2 react versions, there's a conflict with refs that gives the error

Uncaught Error: Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

[AllenFang]

yes, the problem is here:
Module not found: Error: Cannot resolve module 'react-dom/lib/getVendorPrefixedEventName'

So maybe I can try to fix @allenfang/react-toastr again... but It need some time(Start busy now for my work), so PR is welcome.

[CharlieCharlieCharlieCharlie]

for webpack people, I ended up just aliasing react and react-dom to node modules in my config

  react: path.resolve(__dirname, '../node_modules/react'),
  'react-dom': path.resolve(__dirname, '../node_modules/react-dom'),

probably not best practice, if someone has a better idea i'd love to hear it.

[AllenFang]

@celim307, cool, it's also a workaround

[AllenFang]

please check #1216, if you have any concern or question, let me know in #1216

[AllenFang]

After v4.0.0, react-bootstrap-table doesn't use react-toastr` anymore.