Fix runtime async on wasm - #9
Merged
AndyAyersMS merged 1 commit intoJul 24, 2026
Merged
Conversation
- Instead of embedding a table index in the resume info, use a new R2R fixup to place the right PortableEntryPoint into the location - Tweak InterpreterToR2RThunk generation - Always use the standard MehtodSignature for InterpreterToR2RThunks - Build the ArgIterator based on having an async continuation - Always pass 0 as the async continuation parameter. The only case where a non-zero value is passed is on resumptions, and those always pass through the R2R'd resumption stub, not the interpter to R2R thunk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the changes from commit b72152f onto the
wasm-asyncbranch so they can be merged intentionally.Fix runtime async on wasm
PortableEntryPointinto the location.InterpreterToR2RThunkgeneration:MethodSignatureforInterpreterToR2RThunks.ArgIteratorbased on having an async continuation.The single commit was cherry-picked onto the current
wasm-asynctip; it applied cleanly with identical change stats (16 files, +247/-37).Note
This pull request was generated with the assistance of GitHub Copilot.